-
-
Notifications
You must be signed in to change notification settings - Fork 61
fix(deps): adapt shadow configuration for shadow 9.x and update it to v9.2.2 #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This seems like an incorrect or at least an incomplete "fix" |
|
I would assume it is correct since the shadow dev also said that |
shadow 9.0.1 changelog |
|
duplicate non service files should be an error and fail the build. it doesn't seem like a very well thought out change if you can no longer have this behavior while enabling service file merging |
used a different solution |
updated to make it only include the services |
|
I still think this could cause problems if there's files the merger doesn't touch in that dir for whatever reason, but I guess it's probably good enough Still seems kind of like a step backwards to require this extra config for merging to work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good enough for now, thanks
fixes #355
since shadow 9.x, the
INCLUDEduplication strategy has to be specified in order to properly merge service filesThe solution was taken from this shadow issue
This pull request replaces #357