Fixes #18: by including a reference to a collections parent_id if pre… #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unt camelcased classes.
…t/:parent_id/child.parent_id/import_csv explicitly requiring the parents id seems to fix it
…resource Class. This way admin resources they use belongs_to relations can build through the parent chain
…acks aren't supported we needed a way to tap the resource before it was saved.
…tive_admin_csv_import into fix/parent-collection-path
lib/active_admin_csv_import/dsl.rb
Outdated
| resource ||= build_row_resource | ||
|
|
||
| # controller before create callback | ||
| resource = before_create(resource) if respond_to? :before_create |
Contributor
There was a problem hiding this comment.
Could this happen as part of build_row_resource?
Author
|
@tspacek could I get your thoughts on this? |
Member
|
Looks reasonable. |
| end | ||
|
|
||
| def build_row_resource | ||
| resource = end_of_association_chain.new |
Member
There was a problem hiding this comment.
Does build work here instead of new? Might be a bit more idiomatic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sent