Skip to content

Added files for Dwarf Fortress#3430

Open
Plexxl wants to merge 6 commits intoPapirusDevelopmentTeam:masterfrom
Plexxl:master
Open

Added files for Dwarf Fortress#3430
Plexxl wants to merge 6 commits intoPapirusDevelopmentTeam:masterfrom
Plexxl:master

Conversation

@Plexxl
Copy link

@Plexxl Plexxl commented May 11, 2023

Added files for Dwarf Fortress (used for the game downloaded from https://www.bay12games.com/dwarves/), the Arch Package, and the Steam game (https://store.steampowered.com/app/975370/Dwarf_Fortress/)

@SmartFinn
Copy link
Member

Hmm, I notice that all icons are the same size, 64px.

@Plexxl
Copy link
Author

Plexxl commented Aug 7, 2025

After a couple days (give or take) since my last comment here, I finally updated the icons to different sized.

Hopefully this means your oldest PR can go away.

@yukina3230
Copy link

I think it's missing a steam_icon_975370 symlink

@Plexxl
Copy link
Author

Plexxl commented Aug 7, 2025

I think it's missing a steam_icon_975370 symlink

Fixed.

@yukina3230
Copy link

@SmartFinn, hopefully you’ll merge this PR — it will close #3662 and #4005

@Plexxl
Copy link
Author

Plexxl commented Aug 26, 2025

Any update?

@Plexxl
Copy link
Author

Plexxl commented Sep 1, 2025

@SmartFinn ?

@SmartFinn
Copy link
Member

@Plexxl sorry for the late reply. I haven't had any free time to write a review.

Unfortunately, these icons aren't fixed. There are two main problems with them:

  1. The scaling of all these icons isn't equal 1. It makes impossible to create a pixel-perfect icon.
    image
  2. And a classic issue is a lack of Pixel alignment. All edges of objects inside the icon must fit perfectly into the pixel grid.
    image

Try to draw the icons from scratch instead of fixing these. It should be much easier than trying to fix an icon with wrong scaling factor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants