Added files for Dwarf Fortress#3430
Open
Plexxl wants to merge 6 commits intoPapirusDevelopmentTeam:masterfrom
Open
Added files for Dwarf Fortress#3430Plexxl wants to merge 6 commits intoPapirusDevelopmentTeam:masterfrom
Plexxl wants to merge 6 commits intoPapirusDevelopmentTeam:masterfrom
Conversation
Member
|
Hmm, I notice that all icons are the same size, 64px. |
Author
|
After a couple days (give or take) since my last comment here, I finally updated the icons to different sized. Hopefully this means your oldest PR can go away. |
|
I think it's missing a |
Author
Fixed. |
|
@SmartFinn, hopefully you’ll merge this PR — it will close #3662 and #4005 |
Author
|
Any update? |
Author
Member
|
@Plexxl sorry for the late reply. I haven't had any free time to write a review. Unfortunately, these icons aren't fixed. There are two main problems with them:
Try to draw the icons from scratch instead of fixing these. It should be much easier than trying to fix an icon with wrong scaling factor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Added files for Dwarf Fortress (used for the game downloaded from https://www.bay12games.com/dwarves/), the Arch Package, and the Steam game (https://store.steampowered.com/app/975370/Dwarf_Fortress/)