Skip to content

Add LabVIEW icon#4140

Open
GabePoel wants to merge 1 commit intoPapirusDevelopmentTeam:masterfrom
GabePoel:master
Open

Add LabVIEW icon#4140
GabePoel wants to merge 1 commit intoPapirusDevelopmentTeam:masterfrom
GabePoel:master

Conversation

@GabePoel
Copy link
Contributor

@GabePoel GabePoel commented Sep 9, 2025

I made an icon request but then realized I can be the change I want to see in the world. Please let me know if there's any changes that need to be made.

I made an icon request but then realized I can be the change I want to see in the world.
@achadwick
Copy link
Contributor

Hi @GabePoel, sorry for the delay.

Are you still able to work on this? The icons look well aligned, and nicely drawn, and you seem to have run the prepare script. All good so far. Couple of things form a quick review:

  1. Matrix transforms. These can affect some renderers, and are artifacts of previous affine transforms, usually rescaling. Since they seem to be on paths, you'll have to fix each path individually. Putting an individual path in a group and then ungrouping it applies the transform to each point by first moving it to the group, and then applying it to each point of the contained path or paths. You can check in the XML editor (Ctrl+Shift+X) as you go.

  2. Visual contrast. I know the "brand" uses #fecd38 yellow, but it's a low-contrast choice for a white design on top of it. The shadow does help, but it's not perfect, and not testable. If I use https://contrastratio.app and adjust the lightness in Inkscape's slightly off-spec OKHSL selector, I get Lc ≤ -45 for white against #dbae15, and Lc ≤ -30 against the slightly preferable #f6c419. Lc ±45 is minimally suitable for fine icons, and Lc ±30 is minimally suitable for "big chunky" icons. We might be able to squeak by with the latter since the silhouette is a big chunky triangle, what do you think?

Let me know if you want me to handle the mechanistic side of this, for example if you don't have the time to take it forward.

@achadwick achadwick self-assigned this Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants