Add icon for MuseScore

[Naicon67]

Hi it's my first ever contribution to a public repo. I wanted to have the new MuseScore logo, so here it is :)

I'm not entirely sure if it should replace the old one, and I'm not 100% sure about the pixel alignment thing, so please let me know

[p-sage]

This one clearly needs an update, hope your icon will be merged!

[achadwick]

Sorry for the delay. I'll try to review this one shortly.

[achadwick]

Hi, @p-sage - thanks for the contribution. It looks great for a first go!

Are you OK with doing further work on this? There are some small colour and alignment issues.

1. The base is too dark. It can't be darker than #4f4f4f in order to keep dark theme users happy. Could you change it to #4242ac please, which has the same brightness in Inkscape's HSLuv selector.

2. The foreground colour works well against this too, but #0ae1ee might be preferable (Lc -60 at https://datavizcontrast.com/. It just needs to be greater than Lc ±45.

3. The logo needs to be rescaled a little so that it hits pixel boundaries, just like the base already does. I would aim to get the top and bottom aligning with the next pixel size up, while keeping the ratio of width to height. If you can get the centre parallelogram to do the same at its top and bottom, that would be even better! It's OK to distort the shape a little, especially at the smaller sizes, if it's needed for clarity. Whether to distort is always a judgement call.

You may want to consider leaving off the logo's shine, if you think it makes it unclear at pixel sizes.

[Naicon67]

Sure, I will apply those changes, give me a few days. So, I need to align top and bottom of the three light blue shapes, in every pixel size? Is that correct?

[achadwick]

@Naicon67 yes, correct. Hopefully aligning the shape is just a simple scaling up by a fraction of a pixel. Admittedly, regenerating the shadow and highlight can be a bit annoying. Sorry about that 🙇

There are no set rules when dealing with an organic shape like this, not really, but I like to align the outermost convex curves, or vertical/horizontal straight lines of a logo shape to the pixel grid. Anything inside the shape being aligned is not as important as getting the "outline" right [edited. Hope that makes sense!]

Let me know if you need any help.

[Naicon67]

@achadwick just fixed the 64px one. Let me know if that's correct and I will do the other sizes

[achadwick]

@Naicon67 Looks good! Thanks for lifting those colours up too/

When the set is complete, please run ./prepare.sh from inside tools/work before ./put-into-theme.sh (like in your earlier commit). Thanks! It keeps the sizes down, and strips out metadata the icons don't need 😅

[Naicon67]

Done, check it out @achadwick

[Naicon67]

Uhm I see some tests failed @achadwick , is there anything else I need to fix?

[achadwick]

Hi @Naicon67 -

It's looking really nice and sharp now, thanks for the alignment and colour fixes! It looks like prepare.sh just hasn't been run yet, which is why the check is failing.

All the prepare script does is run some optimisations, to strip out Inkscape metadata, remove styles with default values etc. If you update this PR with the following files, the test ought to pass next time it runs. I can merge it then :)

➡️ musescore-workdir-optimized.zip

btw, are you OK with the "Final steps" workflow outlined in tools/work/README.md?

[Naicon67]

Huh that's weird, I did run the scripts. I will give it a try tomorrow, worst case I will ask for some help. Cheers

[Naicon67]

@achadwick I tried multiple times and ways to run the scripts, but the test still failed. It looked like it didn't do anything, my terminal didn't print any errors nor messages. I just copied the files you gave me, but I want to understand why I couldn't run them myself for future work

[achadwick]

@Naicon67
Thanks. Looks like I need to approve the automatic toolchain to run here, so I'll do that now.

I can try to help out with any workflow issues too, if you're interested in working on more icons.

Quick Q: when you run "prepare.sh" and "put-into-theme.sh", do you see output like the output below? If the svgo/scour dependency isn't installed, it will produce error messages instead. Personally, I prefer to use Scour, as a Python enjoyer, and it's pretty widely available now 🐍 You clearly have the Inkscape dependency installed already.

$ pwd
/whatever/your/path/is/to/papirus-icon-theme/tools/work
$ ./prepare.sh
=> Working on './Papirus/apps/musescore@48x48.svg' ...
=> Working on './Papirus/apps/musescore@24x24.svg' ...
=> Working on './Papirus/apps/musescore@32x32.svg' ...
=> Working on './Papirus/apps/musescore@64x64.svg' ...
=> Working on './Papirus/apps/musescore@16x16.svg' ...
=> Working on './Papirus/apps/musescore@22x22.svg' ...

Don't forget, you need to put the newly optimised files in tools/work back into the main tree, so that Git can see the changes. We actually configure Git to ignore SVG files under tools/work because it's intended as a temporary working space for complete sets of icons.

$ pwd
/whatever/your/path/is/to/papirus-icon-theme/tools/work
$ ./put-into-theme.sh
removed './../../Papirus/48x48/apps/musescore.svg'
'./Papirus/apps/musescore@48x48.svg' -> './../../Papirus/48x48/apps/musescore.svg'
removed './../../Papirus/24x24/apps/musescore.svg'
'./Papirus/apps/musescore@24x24.svg' -> './../../Papirus/24x24/apps/musescore.svg'
removed './../../Papirus/32x32/apps/musescore.svg'
'./Papirus/apps/musescore@32x32.svg' -> './../../Papirus/32x32/apps/musescore.svg'
removed './../../Papirus/64x64/apps/musescore.svg'
'./Papirus/apps/musescore@64x64.svg' -> './../../Papirus/64x64/apps/musescore.svg'
removed './../../Papirus/16x16/apps/musescore.svg'
'./Papirus/apps/musescore@16x16.svg' -> './../../Papirus/16x16/apps/musescore.svg'
removed './../../Papirus/22x22/apps/musescore.svg'
'./Papirus/apps/musescore@22x22.svg' -> './../../Papirus/22x22/apps/musescore.svg'

After this, git tools should see pending changes (unless of course the svgo/scour calls just produced the same files)

[achadwick]

@Naicon67 OK, looks like the tests are passing here on github now. I'll do a squash and merge shortly, and then this PR will close and show as merged.

I hope you can get our toils working on your computer. If you have any further difficulties, please open a new topic at https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/issuesusing the "Blank issue" template

• About future Git commit messages: we don't have many conventions here, but I always point people at https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html for general stylistic advice that works with any project. I'm happy to merge this PR with its current messages though.

• Successful test output should look like this. Note that you also need xmlstarlet installed for all the tests to run (I'll update the docs shortly)

$ cd ~/Development/papirus-icon-theme/tools/work/
; your path will be different, of course. Context that doesn't matter is shown as "/path/to" below

$ pwd
/path/to/papirus-icon-theme/tools/work

$ make test
make -C "../.." test
make[1]: Entering directory '/path/to/papirus-icon-theme'
# >>> Searching for icons with rendering glitches
# >>> Searching for non-optimized icons
# >>> Searching for icons with embedded objects
# >>> Searching for broken symlinks
# >>> Searching for invalid icon names
# >>> Detecting decimal numbers in width/height/viewBox attrs
# >>> Detecting lengths units
make[1]: Leaving directory '/path/to/papirus-icon-theme'

[achadwick]

Hi @Naicon67 - just merged 🎉 Thanks so much for the contribution! It's really good stuff.

When I merged, I "squashed" your 4 commits here into a new one, and pushed that to our master branch. That means that your "musecore" branch will now have diverged from the Papirus mainline: feel free to delete it on Github.

If you're having toolchain difficulties, please raise them in a new issue and I can do some general developer support there.

[Naicon67]

My bad, I didn't realize I was editing the .svg outside of the tools/work directory. Happy to see it in main :)