Skip to content

fix: Increase integration OAuth2 access token size#10892

Merged
mattkrick merged 1 commit intomasterfrom
fix/10891/increaseTeamMemberIntegrationAuthAccessTokenSize
Feb 19, 2025
Merged

fix: Increase integration OAuth2 access token size#10892
mattkrick merged 1 commit intomasterfrom
fix/10891/increaseTeamMemberIntegrationAuthAccessTokenSize

Conversation

@Dschoordsch
Copy link
Contributor

Description

Azure DevOps was running into our size limit.
I only found some answer that there is no max size because it's a JWT and depends on the claims. I'm only increasing the token size because there is no reason the refresh token should grow in the same manner.

Fixes #10891

Demo

[If possible, please include a screenshot or gif/video, it'll make it easier for reviewers to understand the scope of the changes and how the change is supposed to work. If you're introducing something new or changing the existing patterns, please share a Loom and explain what decisions you've made and under what circumstances]

Testing scenarios

[Please list all the testing scenarios a reviewer has to check before approving the PR]

  • Scenario A

    • Step 1
    • Step 2...
  • Scenario B

    • Step 1
    • Step 2....

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

Azure DevOps was running into our size limit.
@mattkrick mattkrick merged commit c0134ef into master Feb 19, 2025
8 checks passed
@mattkrick mattkrick deleted the fix/10891/increaseTeamMemberIntegrationAuthAccessTokenSize branch February 19, 2025 05:26
@mattkrick
Copy link
Member

LGTM! crazy that they're passing such large payloads...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GraphQLError: value too long for type character varying(2056)

2 participants