feat: newly created teams are public by default#10961
Merged
nickoferrall merged 24 commits intomasterfrom Mar 18, 2025
Merged
Conversation
nickoferrall
changed the title
2 tasks
Dschoordsch
requested changes
Mar 10, 2025
packages/server/postgres/migrations/2025-03-06T12:25:07.205Z_add-isPublic.ts
Outdated
Show resolved
Hide resolved
| team { | ||
| id | ||
| name | ||
| isPaid |
Contributor
Author
There was a problem hiding this comment.
If we don't include isPaid here, when we join a public team, the emoji suggests it's unpaid until we refresh the page:
| createdBy: userId, | ||
| tier, | ||
| trialStartDate, | ||
| isPublic: true |
Contributor
There was a problem hiding this comment.
+1 This is called in bootstrapNewUser, do we want all onboarding teams to be public?
Contributor
Author
There was a problem hiding this comment.
Yep, all newly created teams should be public by default
Dschoordsch
approved these changes
Mar 12, 2025
Dschoordsch
requested changes
Mar 17, 2025
Contributor
Dschoordsch
left a comment
Dschoordsch
left a comment
There was a problem hiding this comment.
Migration needs to be renamed
Contributor
Author
|
Migration name updated. All of these Public Teams PRs have now been approved, so I'll merge them to master. Thanks for the reviews |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #10924
isPublicset to truepublicTeamsfeature flag haveisPublicset to true, otherwise it's false