fix: bugs found under production load with graphql-yoga #11116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Krick <[email protected]>
…ribe Signed-off-by: Matt Krick <[email protected]>
Signed-off-by: Matt Krick <[email protected]>
mattkrick
changed the title
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #11117
fix #11115
fix #11114
fix #11112
SIGTERM handler was exiting almost immediately because the hocusPocus server, which runs on the same process, was called
process.exit(0)on SIGTERM when it was finished, which meant that the webserver was exiting before it was able to handle its graceful shutdown.