ParabolInc · mattkrick · Apr 7, 2025 · Jan 9, 2025 · Jan 10, 2025 · Jan 10, 2025
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -122,7 +122,7 @@ jobs:
           environment: "production"
           sourcemaps: "./build"
           version: ${{env.ACTION_VERSION}}
-      - name: Push Artifacts to Datadog
+      - name: Push Client Artifacts to Datadog
         env:
           DATADOG_API_KEY: "${{secrets.DATADOG_API_KEY}}"
           CDN_BUILD_URL: "https://action-files.parabol.co/production/build/"
@@ -131,7 +131,14 @@ jobs:
             --service=parabol-saas-production \
             --release-version=${{env.ACTION_VERSION}} \
             --minified-path-prefix=${{env.CDN_BUILD_URL}}
-
+      - name: Push Server Artifacts to Datadog
+        env:
+          DATADOG_API_KEY: "${{secrets.DATADOG_API_KEY}}"
+        run: |
+          yarn datadog-ci sourcemaps upload ./dist \
+            --service=web \
+            --release-version=${{env.ACTION_VERSION}} \
+            --minified-path-prefix="/parabol/dist/"
       - name: Report Status
         if: failure()
         uses: ravsamhq/notify-slack-action@v2

diff --git a/.release-please-manifest.json b/.release-please-manifest.json
@@ -1,3 +1,3 @@
 {
-  ".": "9.0.3"
+  ".": "9.0.4"
 }
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,15 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 This CHANGELOG follows conventions [outlined here](http://keepachangelog.com/).
 
+## [9.0.4](https://github.com/ParabolInc/parabol/compare/v9.0.3...v9.0.4) (2025-04-07)
+
+
+### Fixed
+
+* [#11107](https://github.com/ParabolInc/parabol/issues/11107) push server sourcemaps to dd ([#11119](https://github.com/ParabolInc/parabol/issues/11119)) ([37d4d98](https://github.com/ParabolInc/parabol/commit/37d4d9856fb58db2203ae898dbcc45a4d121ebb1))
+* bugs found under production load with graphql-yoga ([#11116](https://github.com/ParabolInc/parabol/issues/11116)) ([b46ad57](https://github.com/ParabolInc/parabol/commit/b46ad57e8970625b2f930469e7f349be43dcb37d))
+* use abs path ([#11120](https://github.com/ParabolInc/parabol/issues/11120)) ([1d38bc0](https://github.com/ParabolInc/parabol/commit/1d38bc00aa611d682b5e705b02bab4b920288e30))
+
 ## [9.0.3](https://github.com/ParabolInc/parabol/compare/v9.0.2...v9.0.3) (2025-04-04)
 
 

diff --git a/package.json b/package.json
@@ -3,7 +3,7 @@
   "description": "An open-source app for building smarter, more agile teams.",
   "author": "Parabol Inc. <[email protected]> (http://github.com/ParabolInc)",
   "license": "AGPL-3.0",
-  "version": "9.0.3",
+  "version": "9.0.4",
   "repository": {
     "type": "git",
     "url": "https://github.com/ParabolInc/parabol"

diff --git a/packages/chronos/package.json b/packages/chronos/package.json
@@ -1,6 +1,6 @@
 {
   "name": "chronos",
-  "version": "9.0.3",
+  "version": "9.0.4",
   "description": "A cron job scheduler",
   "author": "Matt Krick <[email protected]>",
   "homepage": "https://github.com/ParabolInc/parabol/tree/master/packages/chronos#readme",
@@ -25,6 +25,6 @@
   },
   "dependencies": {
     "cron": "^2.3.1",
-    "parabol-server": "9.0.3"
+    "parabol-server": "9.0.4"
   }
 }
diff --git a/packages/client/package.json b/packages/client/package.json
@@ -3,7 +3,7 @@
   "description": "An open-source app for building smarter, more agile teams.",
   "author": "Parabol Inc. <[email protected]> (http://github.com/ParabolInc)",
   "license": "AGPL-3.0",
-  "version": "9.0.3",
+  "version": "9.0.4",
   "repository": {
     "type": "git",
     "url": "https://github.com/ParabolInc/parabol"

diff --git a/packages/embedder/WorkflowOrchestrator.ts b/packages/embedder/WorkflowOrchestrator.ts
@@ -1,6 +1,6 @@
 import {sql} from 'kysely'
-import RootDataLoader from 'parabol-server/dataloader/RootDataLoader'
 import getKysely from 'parabol-server/postgres/getKysely'
+import {getNewDataLoader} from '../server/dataloader/getNewDataLoader'
 import {EmbedderJobType} from './EmbedderJobType'
 import {JobQueueError} from './JobQueueError'
 import {DBJob, JobType, Workflow} from './custom'
@@ -93,7 +93,7 @@ export class WorkflowOrchestrator {
     if (!step)
       return this.failJob(jobId, retryCount, new JobQueueError(`Step ${stepName} not found`))
     const {run, getNextStep} = step
-    const dataLoader = new RootDataLoader()
+    const dataLoader = getNewDataLoader()
     let result: Awaited<ReturnType<typeof run>> = false
     const data = {...jobData, embeddingsMetadataId, model}
     try {
@@ -104,6 +104,7 @@ export class WorkflowOrchestrator {
         result.stack = e.stack
       }
     }
+    dataLoader.dispose()
     if (result instanceof JobQueueError) return this.failJob(jobId, retryCount, result)
     await this.finishJob(jobId)
     if (result === false) return

diff --git a/packages/embedder/custom.d.ts b/packages/embedder/custom.d.ts
@@ -1,4 +1,4 @@
-import type {DataLoaderInstance} from '../server/dataloader/RootDataLoader'
+import type {DataLoaderWorker} from '../server/graphql/graphql'
 import type {DB} from '../server/postgres/types/pg'
 import {JobQueueError} from './JobQueueError'
 
@@ -8,7 +8,7 @@ type GetInputData<T> = T extends JobQueueStepRun<infer U> ? U : never
 export type ParentJob<T> = GetInputData<T> | GetInputData<T>[]
 
 interface StepContext<TData> {
-  dataLoader: DataLoaderInstance
+  dataLoader: DataLoaderWorker
   data: TData
 }
 

diff --git a/packages/embedder/package.json b/packages/embedder/package.json
@@ -1,6 +1,6 @@
 {
   "name": "parabol-embedder",
-  "version": "9.0.3",
+  "version": "9.0.4",
   "description": "A service that computes embedding vectors from Parabol objects",
   "author": "Jordan Husney <[email protected]>",
   "homepage": "https://github.com/ParabolInc/parabol/tree/master/packages/embedder#readme",

diff --git a/packages/embedder/workflows/helpers/publishSimilarRetroTopics.ts b/packages/embedder/workflows/helpers/publishSimilarRetroTopics.ts
@@ -2,6 +2,7 @@ import {SubscriptionChannel} from '../../../client/types/constEnums'
 import makeAppURL from '../../../client/utils/makeAppURL'
 import appOrigin from '../../../server/appOrigin'
 import {DataLoaderInstance} from '../../../server/dataloader/RootDataLoader'
+import type {DataLoaderWorker} from '../../../server/graphql/graphql'
 import {
   buildCommentContentBlock,
   createAIComment
@@ -42,15 +43,20 @@ const makeSimilarDiscussionLink = async (
   )
 }
 
-const publishComment = async (meetingId: string, commentId: string) => {
+const publishComment = async (
+  meetingId: string,
+  commentId: string,
+  dataLoader: DataLoaderWorker
+) => {
   const data = {commentId, meetingId}
-  publish(SubscriptionChannel.MEETING, meetingId, 'AddCommentSuccess', data, {})
+  const operationId = dataLoader.share()
+  publish(SubscriptionChannel.MEETING, meetingId, 'AddCommentSuccess', data, {operationId})
 }
 
 export const publishSimilarRetroTopics = async (
   embeddingsMetadataId: number,
   similarEmbeddings: {embeddingsMetadataId: number; similarity: number}[],
-  dataLoader: DataLoaderInstance
+  dataLoader: DataLoaderWorker
 ) => {
   const pg = getKysely()
   const links = await Promise.all(
@@ -77,5 +83,5 @@ export const publishSimilarRetroTopics = async (
       discussionId: relatedDiscussionsComment.discussionId
     })
     .execute()
-  publishComment(meetingId, relatedDiscussionsComment.id)
+  publishComment(meetingId, relatedDiscussionsComment.id, dataLoader)
 }
diff --git a/packages/integration-tests/package.json b/packages/integration-tests/package.json
@@ -2,7 +2,7 @@
   "name": "integration-tests",
   "author": "Parabol Inc. <[email protected]> (http://github.com/ParabolInc)",
   "license": "AGPL-3.0",
-  "version": "9.0.3",
+  "version": "9.0.4",
   "description": "",
   "main": "index.js",
   "scripts": {

diff --git a/packages/mattermost-plugin/package.json b/packages/mattermost-plugin/package.json
@@ -1,6 +1,6 @@
 {
   "name": "parabol-mattermost-plugin",
-  "version": "9.0.3",
+  "version": "9.0.4",
   "description": "A service that computes embedding vectors from Parabol objects",
   "author": "Georg Bremer <[email protected]>",
   "homepage": "https://github.com/ParabolInc/parabol/tree/master/packages/mattermost-plugin#readme",
@@ -60,7 +60,7 @@
     "@tiptap/extension-link": "^2.11.5",
     "@tiptap/starter-kit": "^2.11.5",
     "mattermost-redux": "5.33.1",
-    "parabol-client": "9.0.3",
+    "parabol-client": "9.0.4",
     "react-relay": "^18.2.0",
     "react-select": "5.8.2",
     "relay-runtime": "^18.1.1",

diff --git a/packages/server/hocusPocus.ts b/packages/server/hocusPocus.ts
@@ -18,6 +18,7 @@ if (isNaN(port) || port < 0 || port > 65536) {
   throw new Error('Invalid Env Var: HOCUS_POCUS_PORT must be >= 0 and < 65536')
 }
 const server = Server.configure({
+  stopOnSignals: false,
   port,
   quiet: true,
   async onListen(data) {
@@ -92,3 +93,15 @@ const server = Server.configure({
 })
 
 server.listen()
+
+const signalHandler = async () => {
+  await server.destroy()
+  process.exit(0)
+}
+
+process.on('SIGINT', signalHandler)
+process.on('SIGQUIT', signalHandler)
+process.on('SIGTERM', async () => {
+  // DO NOT CALL process.exit(0), let the handler in server.js handle that
+  await server.destroy()
+})
diff --git a/packages/server/package.json b/packages/server/package.json
@@ -3,7 +3,7 @@
   "description": "An open-source app for building smarter, more agile teams.",
   "author": "Parabol Inc. <[email protected]> (http://github.com/ParabolInc)",
   "license": "AGPL-3.0",
-  "version": "9.0.3",
+  "version": "9.0.4",
   "repository": {
     "type": "git",
     "url": "https://github.com/ParabolInc/parabol"
@@ -134,7 +134,7 @@
     "oauth-1.0a": "^2.2.6",
     "openai": "^4.86.1",
     "oy-vey": "^0.12.1",
-    "parabol-client": "9.0.3",
+    "parabol-client": "9.0.4",
     "pg": "^8.5.1",
     "react": "^17.0.2",
     "react-dom": "^17.0.2",

diff --git a/packages/server/utils/publish.ts b/packages/server/utils/publish.ts
@@ -11,20 +11,23 @@ export interface SubOptions {
 
 const REDIS_DATALOADER_TTL = 25_000
 class PublishedDataLoaders {
-  private set = new Set<string>()
-  async add(id: string) {
-    const exists = this.set.has(id)
-    if (exists) return
-    this.set.add(id)
+  private promiseLookup = {} as Record<string, Promise<void>>
+  private async pushToRedis(id: string) {
     const dataLoaderWorker = getInMemoryDataLoader(id)!.dataLoaderWorker
     const str = await serializeDataLoader(dataLoaderWorker)
     // keep the serialized dataloader in redis for long enough for each server to fetch it and make an in-memory copy
     await getRedis().set(`dataLoader:${id}`, str, 'PX', REDIS_DATALOADER_TTL)
     setTimeout(() => {
-      this.set.delete(id)
+      delete this.promiseLookup[id]
       // all calls to publish within a single mutation SHOULD happen within this timeframe
     }, REDIS_DATALOADER_TTL)
   }
+  async add(id: string) {
+    if (!this.promiseLookup[id]) {
+      this.promiseLookup[id] = this.pushToRedis(id)
+    }
+    return this.promiseLookup[id]
+  }
 }
 const publishedDataLoaders = new PublishedDataLoaders()