Skip to content

feat: Disable Suggest Groups button if the free team has exceeded the limit #11133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025

Conversation

tianrunhe
Copy link
Contributor

@tianrunhe tianrunhe commented Apr 8, 2025

Description

To fix this issue🔒

Demo

Screenshot 2025-04-08 at 10 44 19

Testing scenarios

  • Update the MAX_QUAL_AI_MEETINGS to 0
  • Start a retro meeting and see the "Suggest Groups" button is disabled and the tooltip text shows the correct message

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@github-actions github-actions bot added the size/s label Apr 8, 2025
@tianrunhe tianrunhe added the Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved label Apr 8, 2025
@tianrunhe tianrunhe requested a review from nickoferrall April 8, 2025 17:52
Copy link
Contributor

@nickoferrall nickoferrall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the fix!

@tianrunhe tianrunhe merged commit 7e76235 into master Apr 9, 2025
7 checks passed
@tianrunhe tianrunhe deleted the feat/autoGroupPaidLimit branch April 9, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/s Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants