feat: OAuth 2.0 Provider (behind feature flag)#12391
Merged
Dschoordsch merged 21 commits intomasterfrom Jan 13, 2026
Merged
Conversation
fb1d09d to
9a3aec6
Compare
ce26182 to
8da3cea
Compare
8da3cea to
e82a496
Compare
e82a496 to
08df72f
Compare
08df72f to
6df8b15
Compare
6df8b15 to
5722006
Compare
5722006 to
50e5ef7
Compare
50e5ef7 to
edc10b7
Compare
edc10b7 to
1b68e7e
Compare
Contributor
Author
|
Ok @mattkrick , I've made another suite of changes – thanks again for looking this over |
Dschoordsch
requested changes
Jan 5, 2026
packages/server/postgres/migrations/2026-01-12T14:43:00.000Z_addOAuthProvider.ts
Show resolved
Hide resolved
packages/server/postgres/migrations/2025-12-12T23:00:00.000Z_addOAuthProvider.ts
Outdated
Show resolved
Hide resolved
packages/client/modules/userDashboard/components/OrgIntegrations/OAuthAppFormContent.tsx
Show resolved
Hide resolved
packages/server/graphql/public/mutations/deleteOAuthAPIProvider.ts
Outdated
Show resolved
Hide resolved
packages/server/graphql/public/mutations/updateOAuthAPIProvider.ts
Outdated
Show resolved
Hide resolved
packages/server/postgres/migrations/2025-12-12T23:00:00.000Z_addOAuthProvider.ts
Outdated
Show resolved
Hide resolved
|
|
||
| const result = isSuperUser || (isOAuthToken && !!hasScope) | ||
|
|
||
| return result |
Contributor
There was a problem hiding this comment.
-2
We would never enable this feature flag for anybody other than us on SaaS production. Yes, we could use our su tokens, but better if we didn't.
Organization scope feature flags can be enabled by enterprise organizations on their own.
Contributor
Author
|
@Dschoordsch to pick this up |
Contributor
|
Scopes don't work |
Dschoordsch
approved these changes
Jan 13, 2026
Contributor
|
I have tested it with a made up client and added some scope tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements the start of an OAuth 2.0 Provider, configurable from Org Admin and hidden behind a org-level feature flag (
oauthProvider). Note: this is not intended to be a production-ready solution, rather, the a merge-ready solution that can be iterated upon and used for internal testing (or potentially, by self-hosted customers).It provides the following:
oauthProviderfeature flaggraphql:query,graphql:mutationIt does not implement:
.well-knownrouteDemo
https://www.loom.com/share/e129366000ce4164a93c6d20cf6e0213
Testing scenarios
[Please list all the testing scenarios a reviewer has to check before approving the PR]
Can migrate up
Can migrate down
Can migrate up again
Verify that the Org Admin OAuth 2.0 interface is hidden without the feature flag set
Can add the feature flag
See the OAuth Provider Interface after the flag is added
Add a new OAuth 2.0 App
Can save it
Can edit it
Can click regenerate, then cancel secret regeneration
Can click regenerate, then confirm creating a new secret
Can get a token
Can use the token
Final checklist