Skip to content

feat(pages): image block enhancements#12442

Merged
Dschoordsch merged 7 commits intomasterfrom
feat/bigger-page-images
Feb 4, 2026
Merged

feat(pages): image block enhancements#12442
Dschoordsch merged 7 commits intomasterfrom
feat/bigger-page-images

Conversation

@jordanh
Copy link
Contributor

@jordanh jordanh commented Dec 12, 2025

Description

Be the change you want to see in the world. Delivers the following enhancements:

  • Opportunistic placement
  • Allows for resizing of images up to 100%
  • A convenient toggle for full-size or fixed-size image styling
  • A button to download the image
  • A button to replace the image
  • A button to delete the image control

Demo

TODO

Testing scenarios

[Please list all the testing scenarios a reviewer has to check before approving the PR]

  • Add an image block, upload it

  • Resize it

  • Toggle to make it full-width, resize handles disabled

  • Toggle to disable full-width, resize handles re-enabled

  • Download it!

  • Replace it with a different image

  • Delete it

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

  - Opportunistic placement
  - Allows for resizing of images up to 100%
  - A convenient toggle for full-size or fixed-size image styling
  - A button to download the image
  - A button to replace the image
  - A button to delete the image control
@jordanh jordanh force-pushed the feat/bigger-page-images branch from 935a1eb to d28ebcc Compare December 12, 2025 03:20
@github-actions github-actions bot added size/m and removed size/m labels Dec 12, 2025
@Dschoordsch Dschoordsch self-assigned this Jan 16, 2026
@github-actions github-actions bot added size/m and removed size/m labels Jan 29, 2026
@github-actions github-actions bot added size/m and removed size/m labels Jan 29, 2026
Previously we'd set the blob url on the ImageBlock. This would get
synced and result in an invalid blob url for other participants. Instead
we share just a preview id which is locally mapped to said blob url.
@github-actions github-actions bot added size/m and removed size/m labels Jan 29, 2026
@Dschoordsch Dschoordsch marked this pull request as ready for review January 29, 2026 15:41
@github-actions github-actions bot requested a review from Dschoordsch January 29, 2026 15:41
@github-actions github-actions bot added size/m and removed size/m labels Jan 30, 2026
Copy link
Contributor

@Dschoordsch Dschoordsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to be merged once production and staging are in sync again.

@Dschoordsch Dschoordsch merged commit 6a8d45a into master Feb 4, 2026
7 checks passed
@Dschoordsch Dschoordsch deleted the feat/bigger-page-images branch February 4, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants