Skip to content

Fortran declaration of string variable to use character(LEN=*) form #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025
Merged

Fortran declaration of string variable to use character(LEN=*) form #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/F77/block_cyclic.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ program main
integer NY, NX
PARAMETER(NX=10, NY=4)

character*256 filename, cmd
character(LEN=256) filename, cmd
integer i, j, rank, nprocs, err, ierr, num_reqs, get_args
integer ncid, cmode, varid, dimid(2), stride, block_len
integer buf(NX, NY)
Expand Down
2 changes: 1 addition & 1 deletion examples/F77/bput_varn_int8.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ program main
integer*8 NX, NY
PARAMETER(NDIMS=2, NX=10, NY=4)

character*256 filename, cmd
character(LEN=256) filename, cmd
integer i, j, k, n, err, ierr, nprocs, rank, get_args
integer cmode, ncid, varid(4), dimid(NDIMS), nreqs
integer reqs(4), sts(4), num_segs(4)
Expand Down
2 changes: 1 addition & 1 deletion examples/F77/column_wise.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ program main
integer NY, NX
PARAMETER(NX=10, NY=4)

character*256 filename, cmd
character(LEN=256) filename, cmd
integer i, j, rank, nprocs, err, ierr, num_reqs, get_args
integer ncid, cmode, varid, dimid(2)
integer buf(NX, NY)
Expand Down
2 changes: 1 addition & 1 deletion examples/F77/fill_mode.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ program main
include 'mpif.h'
include 'pnetcdf.inc'

character*256 filename, cmd
character(LEN=256) filename, cmd
integer i, j, err, ierr, nprocs, rank, get_args
integer cmode, ncid, rec_varid, fix_varid, dimid(2)
integer no_fill, fill_value, old_mode
Expand Down
2 changes: 1 addition & 1 deletion examples/F77/flexible_api.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ program main
include "mpif.h"
include "pnetcdf.inc"

character*256 filename, cmd
character(LEN=256) filename, cmd
integer err, ierr, nprocs, rank, i, j, ghost_len, get_args
integer cmode, ncid, varid, dimid(2)
integer*8 nx, ny, global_nx, global_ny
Expand Down
6 changes: 3 additions & 3 deletions examples/F77/get_info.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ program main
include "mpif.h"
include "pnetcdf.inc"

character*256 filename, cmd
character(LEN=256) filename, cmd
integer ncid, rank, info, cmode, err, ierr, get_args
integer*8 malloc_size, sum_size
logical verbose
Expand Down Expand Up @@ -102,7 +102,7 @@ subroutine print_info(info_used)
integer info_used

! local variables
character*(MPI_MAX_INFO_VAL) key, value
character(LEN=MPI_MAX_INFO_VAL) key, value
integer nkeys, i, err
logical flag

Expand All @@ -126,7 +126,7 @@ subroutine handle_err(err_msg, errcode)
include "mpif.h"
include "pnetcdf.inc"

character*(*) err_msg
character(LEN=*) err_msg
integer errcode

! local variables
Expand Down
4 changes: 2 additions & 2 deletions examples/F77/hints.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ subroutine print_hints(ncid, varid0, varid1)
integer ncid, varid0, varid1
! local variables
character*(MPI_MAX_INFO_VAL) value
character(LEN=MPI_MAX_INFO_VAL) value
integer err, len, info_used
logical flag
integer*8 header_size, header_extent
Expand Down Expand Up @@ -133,7 +133,7 @@ program main
include "mpif.h"
include "pnetcdf.inc"
character*256 filename, cmd
character(LEN=256) filename, cmd
integer NZ, NY, NX
integer ncid, rank, nprocs, info, cmode, err, ierr, get_args
integer varid0, varid1, dimid(3), dimid2(2)
Expand Down
2 changes: 1 addition & 1 deletion examples/F77/i_varn_real.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ program main
integer*8 NX, NY
PARAMETER(NDIMS=2, NX=4, NY=10)

character*256 filename, cmd
character(LEN=256) filename, cmd
integer i, j, n, err, ierr, nprocs, rank, get_args
integer cmode, ncid, varid(4), dimid(NDIMS), nreqs
integer reqs(4), sts(4), num_segs(4)
Expand Down
2 changes: 1 addition & 1 deletion examples/F77/nonblocking_write.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ program main
integer NDIMS, NUM_VARS, BUFSIZE
PARAMETER(NDIMS=3, NUM_VARS=10, BUFSIZE=1000)

character*256 filename, cmd, str
character(LEN=256) filename, cmd, str
integer i, j, cmode, err, ierr, get_args, info
integer rank, nprocs, ncid, len
integer buf(BUFSIZE, NUM_VARS), buf1d(BUFSIZE)
Expand Down
2 changes: 1 addition & 1 deletion examples/F77/put_vara.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ program main
include 'mpif.h'
include 'pnetcdf.inc'

character*256 filename, cmd
character(LEN=256) filename, cmd
integer i, j, err, ierr, nprocs, rank, get_args, dummy
integer cmode, ncid, varid, dimid(2)
integer*8 nx, ny, global_nx, global_ny
Expand Down
2 changes: 1 addition & 1 deletion examples/F77/put_varn_int.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ program main
integer*8 NX, NY
PARAMETER(NDIMS=2, NX=4, NY=10)

character*256 filename, cmd
character(LEN=256) filename, cmd
integer i, j, err, ierr, nprocs, rank, get_args, dummy
integer cmode, ncid, varid, dimid(NDIMS), num_reqs
integer old_fillmode
Expand Down
2 changes: 1 addition & 1 deletion examples/F77/put_varn_real.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ program main
integer NDIMS
PARAMETER(NDIMS=2)

character*256 filename, cmd
character(LEN=256) filename, cmd
integer rank, nprocs, err, num_reqs, ierr, get_args, dummy
integer i, j, ncid, cmode, varid, dimid(2), y, x, old_fillmode
real buffer(13)
Expand Down
8 changes: 4 additions & 4 deletions examples/F77/time_var.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ subroutine pnetcdf_write(filename, mode)
include 'mpif.h'
include 'pnetcdf.inc'

character*256 filename
character(LEN=256) filename
integer mode

! local variables
Expand Down Expand Up @@ -176,15 +176,15 @@ subroutine pnetcdf_read(filename)
include 'mpif.h'
include 'pnetcdf.inc'

character*256 filename
character(LEN=256) filename

! local variables
integer j, err, nprocs, rank
integer ncid, rec_var, fix_var, dim_t, dim_y, dim_x
integer*8 i, nx, ny, global_nx, global_ny, time_len, local_nx
integer*8 start(2), count(2), str_len
PARAMETER(nx=3, ny=4)
character*256 str_att
character(LEN=256) str_att
double precision buf(nx,ny), expect

call MPI_Comm_rank(MPI_COMM_WORLD, rank, err)
Expand Down Expand Up @@ -311,7 +311,7 @@ program main
include 'mpif.h'
include 'pnetcdf.inc'

character*256 filename, cmd
character(LEN=256) filename, cmd
integer err, ierr, rank, get_args, dummy
integer*8 malloc_size, sum_size
logical verbose
Expand Down
2 changes: 1 addition & 1 deletion examples/F77/transpose.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ program main
include 'mpif.h'
include 'pnetcdf.inc'

character*256 filename, cmd
character(LEN=256) filename, cmd
integer err, ierr, nprocs, rank, lower_dims, get_args, dummy
integer cmode, ncid, psizes(3), dimids(3), dimidsT(3)
integer XYZ_id, XZY_id, YZX_id, YXZ_id, ZYX_id, ZXY_id
Expand Down
2 changes: 1 addition & 1 deletion examples/F77/vard_int.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ program main
implicit none
include "mpif.h"
include "pnetcdf.inc"
character*256 filename, cmd
character(LEN=256) filename, cmd
integer err, ierr, nprocs, rank, i, j, get_args, dummy
integer cmode, ncid, varid0, varid1, dimid(2)
integer*8 NX, NY, len, bufcount
Expand Down
4 changes: 2 additions & 2 deletions examples/F90/get_info.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ subroutine print_info(info_used)
integer, intent(in) :: info_used

! local variables
character*(MPI_MAX_INFO_VAL) key, value
character(LEN=MPI_MAX_INFO_VAL) key, value
integer nkeys, i, err
logical flag

Expand All @@ -125,7 +125,7 @@ subroutine handle_err(err_msg, errcode)
use pnetcdf
implicit none

character*(*), intent(in) :: err_msg
character(LEN=*), intent(in) :: err_msg
integer, intent(in) :: errcode

! local variables
Expand Down
2 changes: 1 addition & 1 deletion examples/F90/hints.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ subroutine print_hints(ncid, varid0, varid1)
integer ncid, varid0, varid1

! local variables
character*(MPI_MAX_INFO_VAL) value
character(LEN=MPI_MAX_INFO_VAL) value
integer err, len, info_used
logical flag
integer(kind=MPI_OFFSET_KIND) header_size, header_extent
Expand Down
2 changes: 1 addition & 1 deletion examples/tutorial/pnetcdf-write-bufferedf77.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ program main
integer*8 start(2), count(2), stride(2), imap(2)
integer*8 bufsize, put_size, dim_size
real var(6,4)
character*256 filename, cmd
character(LEN=256) filename, cmd
logical verbose

call MPI_INIT(err)
Expand Down
4 changes: 2 additions & 2 deletions test/fandc/pnf_test.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ subroutine Write_File
! Argument declarations.
! ----------------------

character*(*) filename
character(LEN=*) filename
integer nwrites
integer mype
integer comm_cart
Expand Down Expand Up @@ -385,7 +385,7 @@ subroutine Read_File
! Argument declarations.
! ----------------------

character*(*) filename
character(LEN=*) filename
integer nreads
integer mype
integer comm_cart
Expand Down
8 changes: 4 additions & 4 deletions test/largefile/bigrecords.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
! time variable will be garbled.

INTEGER FUNCTION XTRIM(STRING)
CHARACTER*(*) STRING
CHARACTER(LEN=*) STRING
INTEGER I, N
N = LEN(STRING)
DO I = N, 1, -1
Expand Down Expand Up @@ -88,7 +88,7 @@ program main
+ 377.5, 367.59, 360.06, 353.85999, 348.66, 342.5, 336, 328.5, 320,
+ 310, 300, 290, 280, 270, 260, 250, 240, 230, 220, 210, 199.10001/

character*256 filename, cmd, msg
character(LEN=256) filename, cmd, msg

! attribute vectors
! enter define mode
Expand Down Expand Up @@ -271,7 +271,7 @@ subroutine writerecs(cmd,ncid,time_id)
include "mpif.h"
include "pnetcdf.inc"

character*(*) cmd
character(LEN=*) cmd
! netCDF id
integer ncid
! variable ids
Expand Down Expand Up @@ -328,7 +328,7 @@ subroutine check_err(cmd, msg, iret)

include "pnetcdf.inc"

character*(*) cmd, msg
character(LEN=*) cmd, msg
integer iret
integer XTRIM

Expand Down
12 changes: 6 additions & 6 deletions test/nf90_test/nf90_error.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
subroutine error(msg)
use pnetcdf
implicit none
character*(*) msg
character(LEN=*) msg
#include "tests.inc"

nfails = nfails + 1
Expand All @@ -25,7 +25,7 @@ subroutine error(msg)
subroutine errori(msg, i)
use pnetcdf
implicit none
character*(*) msg
character(LEN=*) msg
integer i
#include "tests.inc"

Expand All @@ -40,7 +40,7 @@ subroutine errori(msg, i)
subroutine errord(msg, d)
use pnetcdf
implicit none
character*(*) msg
character(LEN=*) msg
doubleprecision d
#include "tests.inc"

Expand All @@ -55,8 +55,8 @@ subroutine errord(msg, d)
subroutine errorc(msg, string)
use pnetcdf
implicit none
character*(*) msg
character*(*) string
character(LEN=*) msg
character(LEN=*) string
#include "tests.inc"

nfails = nfails + 1
Expand All @@ -71,7 +71,7 @@ subroutine errorc(msg, string)
subroutine errore(msg, err)
use pnetcdf
implicit none
character*(*) msg
character(LEN=*) msg
integer err
#include "tests.inc"

Expand Down
10 changes: 5 additions & 5 deletions test/nf90_test/nf90_test.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ subroutine usage()

subroutine report_test
implicit none
character*1024 msg
character(LEN=1024) msg
#include "tests.inc"

if (cdf_format .EQ. 4) then
Expand All @@ -69,7 +69,7 @@ subroutine report_test
subroutine test(name, func)
use pnetcdf
implicit none
character*(*) name
character(LEN=*) name
character(len=25) name_str
integer name_len
external func
Expand Down Expand Up @@ -100,7 +100,7 @@ subroutine getarg(iarg, carg)
use pnetcdf
implicit none
integer iarg
character*(*) carg
character(LEN=*) carg
integer ilen
integer ierror
call PXFGETARG(iarg, carg, ilen, ierror)
Expand Down Expand Up @@ -128,10 +128,10 @@ program nf90_test
#include "tests.inc"

integer argc
character*80 arg
character(LEN=80) arg
integer iarg
integer iopt
character*1 opt
character(LEN=1) opt
integer lastopt
logical skiparg
integer err
Expand Down
2 changes: 1 addition & 1 deletion test/nf90_test/test_get.m4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,7 +1078,7 @@ define([TEST_NFMPI_GET_ATT],dnl
use pnetcdf
implicit none
#include "tests.inc"
character*2 ATT_NAME
character(LEN=2) ATT_NAME
integer ATT_TYPE, NATTS, ATT_LEN
double precision hash4
logical equal, inRange3, in_internal_range
Expand Down
Loading
Loading