Refactor WebSocket Message Handling: Centralized Dispatch, Type Safety, and Optimized Routing #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai-kumar-peddireddy
requested review from
alevlasu,
bineesh-n and
cjlapao
as code owners
github-project-automation
bot
moved this to 📋 Awaiting Triage
in Parallels DevOps Service
cjlapao
reviewed
Nov 20, 2025
…y, and Optimized Routing - HealthService: Implemented a singleton HealthService to handle health events (e.g., ping -> pong) using a decoupled Broadcaster interface. - SystemHandler: Implemented a singleton SystemHandler to handle system events (e.g., client-id) using a decoupled Broadcaster interface. - Optimized Routing: Refactored handleClientMessage to avoid double-marshaling. It now performs partial parsing of the header and passes the raw []byte payload directly to handlers via RouteMessageCmd. - Centralized Dispatch: Enhanced the Hub's handler registry to use a map-based set for automatic deduplication and O(1) lookups. - Type Safety: Enforced usage of constants.EventType throughout the system - Testing: Added comprehensive unit tests for HealthService, SystemHandler, and Client (Reader/Writer/Handler), significantly improving code coverage.
sai-kumar-peddireddy
force-pushed
the
msg-routing-from-websock-client
branch
from
10dbe86 to
264e3fe
Compare
cjlapao
approved these changes
Nov 20, 2025
github-project-automation
bot
moved this from 📋 Awaiting Triage
to ✅ Done
in Parallels DevOps Service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #319
Type of change
Checklist