Skip to content

fix: resolve code quality issues across contracts #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nonsobethel0-dev merged 1 commit into from
Aug 28, 2026
Merged

fix: resolve code quality issues across contracts #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions contracts/claims-processor/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
#![allow(dead_code)]
#![allow(unused_imports)]
// Address/state validation must fail with a typed contract error so callers
// can match on it programmatically, never with a raw panic! and a string
// message.
Expand Down
2 changes: 0 additions & 2 deletions contracts/oracle-verifier/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,9 @@ pub enum Error {

// ─── Contract ─────────────────────────────────────────────────────────────────

#[cfg(any(test, feature = "testutils", not(feature = "library")))]
#[contract]
pub struct OracleVerifier;

#[cfg(any(test, feature = "testutils", not(feature = "library")))]
#[contractimpl]
impl OracleVerifier {
// ── Lifecycle ────────────────────────────────────────────────────────────
Expand Down
4 changes: 0 additions & 4 deletions contracts/policy-engine/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,13 @@ const ADMIN_TRANSFER_TIMELOCK: u64 = 48 * 60 * 60;

/// Upper bound on the number of policies `batch_buy_policy` will create in one
/// call, so a single transaction cannot blow Soroban's instruction budget.
#[cfg(any(test, feature = "testutils", not(feature = "library")))]
const MAX_BATCH_BUY: u32 = 20;

// ─── Pagination ───────────────────────────────────────────────────────────────

/// Upper bound on the number of entries a paginated query will return in one
/// call. Without a cap, a caller could pass `limit = u32::MAX` and force the
/// contract to build one huge `Vec`, blowing Soroban's instruction budget.
#[cfg(any(test, feature = "testutils", not(feature = "library")))]
const MAX_PAGE_SIZE: u32 = 100;

// ─── Storage keys ─────────────────────────────────────────────────────────────
Expand Down Expand Up @@ -190,11 +188,9 @@ pub enum Error {

// ─── Contract ─────────────────────────────────────────────────────────────────

#[cfg(any(test, feature = "testutils", not(feature = "library")))]
#[contract]
pub struct PolicyEngine;

#[cfg(any(test, feature = "testutils", not(feature = "library")))]
#[contractimpl]
impl PolicyEngine {

Expand Down
Loading