-
Notifications
You must be signed in to change notification settings - Fork 168
Changing time and dt inside kernel loop to float
#2405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
erikvansebille
wants to merge
26
commits into
v4-dev
Choose a base branch
from
time_dt_as_float
base: v4-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+377
−415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And fixing most unit tests; one breaking unit test remaining
And also adding a unit test
As not necessary anymore
Contributor
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only managed to do a partial review today, looks good for the most part - will finish tomorrow. I went ahead and pushed the refactor e479387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2130, using
np.timedelta64andnp.datetime64as core data structured forparticles.dtandparticles.timebrings some major issues:timedelta64dt, see Issue with unevendtand RK advection #2380This PR therefore implements a revert to the v3 approach, where
timeanddtarefloatsthroughout the Kernel. This also allows (later) integration withpintfor unit-aware computations in the KernelDuring development, I also came across a bug in RK45 (fixed in 18a4590), which needs a
particles.next_dtvariable in order to be able to increase dt in the Kernel loop (otherwise, displacements are computed with the old dt, but the time-update is with the new dt).