Simplify TudeeBottomSheet height logic #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the vertical drag gesture handling in `TudeeBottomSheet.kt`. The changes include: - Removing the concept of predefined `allowedHeights` and the `findClosestHeight` function. - Simplifying the drag logic to directly adjust `currentHeight`. - Hiding the bottom sheet when `currentHeight` falls below 200.dp during a drag. - Removing an unnecessary `@file:OptIn(ExperimentalMaterial3Api::class)` annotation.
Joseph-Sameh-0
requested review from
Asmaa7071,
DinaOthman21,
IslamMagd,
M-Abdelnabi,
Mohamed-Elhanafy,
MuhammedWael9991,
MustafaIbrahim96,
Renad-Alalfy,
ahmedNaser7,
itsahmedsalah and
yousef-osama11
DinaOthman21
approved these changes
Jun 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr refactors the vertical drag gesture handling in
TudeeBottomSheet.kt.The changes include:
allowedHeightsand thefindClosestHeightfunction.currentHeight.currentHeightfalls below 200.dp during a drag.