Skip to content

prepare-for-core-upgrade #5466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
danielmarbach wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

prepare-for-core-upgrade #5466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf5bbd0
Use alpha
danielmarbach May 8, 2026
71f19ec
Remove no longer needed extension methods
danielmarbach May 8, 2026
19eb5b2
Acceptance testing alpha
danielmarbach May 8, 2026
03d5675
RegisterComponent
danielmarbach May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
<PackageVersion Include="Microsoft-WindowsAPICodePack-Shell" Version="1.1.5" />
<PackageVersion Include="Mindscape.Raygun4Net.NetCore" Version="11.2.5" />
<PackageVersion Include="NLog.Extensions.Logging" Version="6.1.3" />
<PackageVersion Include="NServiceBus" Version="10.1.4" />
<PackageVersion Include="NServiceBus.AcceptanceTesting" Version="10.1.4" />
<PackageVersion Include="NServiceBus" Version="10.2.0-alpha.8" />
<PackageVersion Include="NServiceBus.AcceptanceTesting" Version="10.2.0-alpha.8" />
<PackageVersion Include="NServiceBus.AmazonSQS" Version="9.0.1" />
<PackageVersion Include="NServiceBus.CustomChecks" Version="6.0.1" />
<PackageVersion Include="NServiceBus.Extensions.Hosting" Version="4.0.1" />
Expand All @@ -52,7 +52,7 @@
<PackageVersion Include="NServiceBus.Transport.Msmq.Sources" Version="4.0.1" />
<PackageVersion Include="NServiceBus.Transport.PostgreSql" Version="9.0.1" />
<PackageVersion Include="NServiceBus.Transport.SqlServer" Version="9.0.1" />
<PackageVersion Include="NServiceBus.Transport.IBMMQ" Version="1.0.1"/>
<PackageVersion Include="NServiceBus.Transport.IBMMQ" Version="1.0.1" />
<PackageVersion Include="NuGet.Versioning" Version="7.3.1" />
<PackageVersion Include="NUnit" Version="4.6.0" />
<PackageVersion Include="NUnit.Analyzers" Version="4.13.0" />
Expand Down Expand Up @@ -94,4 +94,4 @@
<GlobalPackageReference Include="Microsoft.Build.CopyOnWrite" Version="1.0.334" />
<GlobalPackageReference Include="Particular.Packaging" Version="4.5.0" />
</ItemGroup>
</Project>
</Project>
4 changes: 2 additions & 2 deletions ...ceControl.AcceptanceTests/Recoverability/ExternalIntegration/When_encountered_an_error.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ public async Task Should_restart_dispatch_thread()
{
var externalProcessorSubscribed = false;

CustomizeHostBuilder = builder => builder.Services.AddSingleton<IEventPublisher, FaultyPublisher>();

CustomConfiguration = config =>
{
config.OnEndpointSubscribed<MyContext>((s, ctx) =>
Expand All @@ -37,8 +39,6 @@ public async Task Should_restart_dispatch_thread()
externalProcessorSubscribed = true;
}
});

config.RegisterComponents(services => services.AddSingleton<IEventPublisher, FaultyPublisher>());
};

ExecuteWhen(() => externalProcessorSubscribed, domainEvents => domainEvents.Raise(new EndpointFailedToHeartbeat
Expand Down
8 changes: 2 additions & 6 deletions src/ServiceControl.MultiInstance.AcceptanceTests/Auditing/When_requesting_a_message_body.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,10 @@ class MyMessage : ICommand

class RemoteEndpoint : EndpointConfigurationBuilder
{
public RemoteEndpoint() => EndpointSetup<DefaultServerWithAudit>(c => c.RegisterComponents(services => services.AddSingleton<IMutateIncomingTransportMessages, MessageBodySpy>()));
public RemoteEndpoint() => EndpointSetup<DefaultServerWithAudit, MyContext>((c, context) => c.RegisterMessageMutator(new MessageBodySpy(context)));

public class MessageBodySpy : IMutateIncomingTransportMessages
public class MessageBodySpy(MyContext testContext) : IMutateIncomingTransportMessages
{
readonly MyContext testContext;

public MessageBodySpy(MyContext testContext) => this.testContext = testContext;

public Task MutateIncoming(MutateIncomingTransportMessageContext context)
{
testContext.MessageContentType = context.Headers[Headers.ContentType];
Expand Down
1 change: 0 additions & 1 deletion src/ServiceControl.Transports.Tests/BasicEndpointSetup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ public async Task<EndpointConfiguration> GetConfiguration(RunDescriptor runDescr
var endpointConfiguration = new EndpointConfiguration(endpointCustomization.EndpointName);

endpointConfiguration.UseSerialization<SystemJsonSerializer>();
endpointConfiguration.RegisterComponentsAndInheritanceHierarchy(runDescriptor);

var recoverability = endpointConfiguration.Recoverability();
recoverability.Immediate(c => c.NumberOfRetries(3));
Expand Down
24 changes: 0 additions & 24 deletions src/ServiceControl.Transports.Tests/EndpointTestExtensions.cs
View file
Open in desktop

This file was deleted.

Loading