Skip to content

Ensure that we update all HELM_CHART_VERSION lines#10

Merged
PatAKnight merged 1 commit into
mainfrom
update-version-bump-fix
Feb 23, 2026
Merged

Ensure that we update all HELM_CHART_VERSION lines#10
PatAKnight merged 1 commit into
mainfrom
update-version-bump-fix

Conversation

@PatAKnight

@PatAKnight PatAKnight commented Feb 16, 2026

Copy link
Copy Markdown
Owner

Summary

Quick bug fix where we were missing the HELM_CHART_VERSION from within the deploy/configmap.yaml when running the update-rhdh-version workflow. This isn't terribly important because the env variable is set by env_variables.sh as well. But it is nice to have these be consistent.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • New plugin support (adds integration for a new RHDH plugin)
  • Documentation update
  • Refactoring (no functional changes)
  • CI/CD changes

Related Issues

Closes #(issue number)

Changes Made

  • Adds a line to target the deploy/configmap.yaml

Checklist

General

  • I have read the CONTRIBUTING guide
  • My code follows the project's code conventions
  • I have tested my changes against a real cluster
  • If upgrading RHDH version, verified values.yaml is compatible with new chart

Security

  • No secrets, tokens, or credentials are included in this PR
  • Secret templates contain only placeholders (empty strings or <PLACEHOLDER>)
  • No hardcoded cluster URLs or API endpoints

For Plugin Contributions

  • Documentation added in docs/<plugin-name>.md
  • Configuration script added in scripts/config-<plugin-name>-plugin.sh
  • config-plugins.sh updated with new mappings
  • Secret templates updated with new placeholders
  • Resource manifests added (if required)
  • All new scripts are executable (chmod +x)

Testing Notes

Describe how you tested these changes:

Screenshots (if applicable)

Add screenshots to help explain your changes.

Signed-off-by: Patrick Knight <pknight@redhat.com>
@PatAKnight PatAKnight merged commit 5018365 into main Feb 23, 2026
1 of 3 checks passed
@PatAKnight PatAKnight deleted the update-version-bump-fix branch February 23, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant