Fix K8S_CLUSTER_URL discovery when running as a K8s job#14
Merged
Conversation
Signed-off-by: Patrick Knight <pknight@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where the K8S_CLUSTER_URL isn't discovered when running as a job. This fix resolves that problem by checking if the scripts are running inside the cluster and then querying for the api endpoint of the cluster.
Type of Change
Related Issues
Closes #(issue number)
Changes Made
Checklist
General
values.yamlis compatible with new chartSecurity
<PLACEHOLDER>)For Plugin Contributions
docs/<plugin-name>.mdscripts/config-<plugin-name>-plugin.shconfig-plugins.shupdated with new mappingschmod +x)Testing Notes
Describe how you tested these changes:
Screenshots (if applicable)
Add screenshots to help explain your changes.