Add support for "while wielding a Quarterstaff" (One with the River)#1074
Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom May 1, 2025
Merged
Conversation
LocalIdentity
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1055.
Description of the problem being solved:
Adding support for the Quarterstaff tag that wasn't there alongside other similar ones ("while wielding a spear" mod is also missing, but doesn't exist on the tree/item so far)
Also, the "UsingStaff" tag seems to work only with Quarterstaves now and its a bit misleading, + there is no Staff tag itself (which makes node/modifier work as intended, but may be problematic later if those staff mods would appear)