Fix Beidat's Hand Energy Shield per Max Life mod not working#1113
Merged
LocalIdentity merged 2 commits intoPathOfBuildingCommunity:devfrom May 7, 2025
Merged
Fix Beidat's Hand Energy Shield per Max Life mod not working#1113LocalIdentity merged 2 commits intoPathOfBuildingCommunity:devfrom
LocalIdentity merged 2 commits intoPathOfBuildingCommunity:devfrom
Conversation
The PerStat mod from the Beidat's Hand Infernalist ascendancy notable did not work due to Life amount not being present in the output at the time of calculation of globalBase EnergyShield. This pr attempts to fix this by running the doActorLifeManaSpirit before calculating the primary defences and then again after to account for potential conversion mods. This should work correctly as any values written by doActorLifeManaSpirit should be overwritten by the second call. I'm currently unsure whether there are edge cases that could cause issues with this proposed solution. Signed-off-by: Paliak <91493239+Paliak@users.noreply.github.com>
LocalIdentity
approved these changes
May 7, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #224
Description of the problem being solved:
The PerStat mod from the Beidat's Hand Infernalist ascendancy notable did not work due to Life amount not being present in the output at the time of calculation of globalBase EnergyShield. This pr attempts to fix this by running the doActorLifeManaSpirit before calculating the primary defences and then again after to account for potential conversion mods. This should work correctly as any values written by doActorLifeManaSpirit should be overwritten by the second call. I'm currently unsure whether there are cases that could cause issues with this proposed solution.
Steps taken to verify a working solution:
-Test the mod by itself
-Test with GhostWrithe (PerStat applies after conversion, is that correct?)
Link to a build that showcases this PR: