Skip to content

Fix missing area base flag on concoction skills#1114

Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
Paliak:issue-1112
May 7, 2025
Merged

Fix missing area base flag on concoction skills#1114
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
Paliak:issue-1112

Conversation

@Paliak
Copy link
Copy Markdown
Contributor

@Paliak Paliak commented May 7, 2025

Fixes #1112

Description of the problem being solved:

Concoctions skills seem to be missing area base flags which is causing them to not have the ModFlag.Area bit flag set in CalcActiveSkill. This makes the area more damage mod from Concentrated Effect not apply.

Link to a build that showcases this PR:

eNrVXNty4zYSfR5_BUpV2dqtyVgiqYvtlZOSb2NX2WNHsmc2TymYhCyuIVIhQdtKav59uwHeJBMkaO9DkocMRZzuBg4aQKMBevzzy5KTJxbFfhgcdqzdXoewwA09P3g47Nzdnn3a6_z80874horF9fwo8TmW2D_tfBjLH4SzJ8ZBsENcTuP4C12yw86UBg8s6hAauyzwjosCVDP3Aw8LBY0emPiame79hjoWNKKuYNElqp0kIrwKPZATUcI6ZEn9YBa6j0x8jsJkJa0--exZYS6ubq6ntx2o2ofxDadrFs0EFSSG_x12JtBE-sBO6BL-D1KUJyCy1xvsDgZDa98Z7A-cUadbK3yURLF4m4bZijEvF7J2-zrgTcRO53PmCv-JHUe-OF7QwC3MDXRybbFXCRf-ivvYESne1uHPX6m2ej0d-DYUlJ_czAqsZY92R6O94cjqOc6gXi4UuZzWwhEHLssWgPvdkWOPRkN71BtaOrlvvli8krV7Q2d3YFn9_sjp9WtlLx4CX7A3NA2Fb0I_DoN38PKGBh8nnMNgLUtqSZ2ymEVPVPibldTij8PlvR-8ictJxOj1XHn5lHp-El8xEbG4NDy0bFzRgB6HsYGXIPKGRTD_iFYCM-aGMGW1tdFS8tKfM3Nkq3akAm1r87Z2nM5Mca0Vv61CU5iczZCzMOGGSFFMktoZ_oS9FA6s9d-LQJioegpxIDbXTE4Op-c3xZzf23Ws4XC05-wP-vtD7SqzWMe-S_kVffGXyRIm-Fv6yAqDw4HeVR4WIoBZRSfa1xo98yPWXuo45N4bpBY0jNu37goCjHMaeBPXTSAOWRd9pRU5odFjwOLYdIqFKdNYAselQa0huHAPEHsRuM2rPwLvgiitjFGXz9kUhiAGQfecGUoUJtKBbBI8KFMPLEjtrc04umTMXXyGvptSwcym7cKH9mppRWyZ1lqlFbTq1W8KtCAJBatJsnb364Ra0jRb-RAomtRIISta30KmBQGnAYse1rOFz7hnsJKU0Bljx3Rl0n7o_7K0kR9smmvlymXRln2Fy15ba080Li8yTgMRCm42FhiE2SDgsa19Q0-_7Qn_i5se3k5sEi3DJDLsSgU2akC2PqrN3pR5iWu2IOd7tyMO-1TTZuRSUE_OW4lOhKDu40noPRiTJo20ktis3yxZrWDUojeYKsClH5Y_vxRtfeoboK_BlY3GKkYJ5gYKtLGBPO4xt7IlYt4WjF22zJiAjQ3k3XkFU8USJl2ZnbgKS_N2TXoiZtDllfs2bVLjDDaiRrtKCdzc6-rHaPgM7V1gEiluh4a4sJj1tFWJWPDH2lj_BtzIwGngQYwJXBrb2JaoMnOUzOcxcWF3TsUlOMVhp0Pu4V32DHFtzNIfSuLWX8J0HccnVFDipVuPrzTyaSBsmWKLGY3cBQqdUc7vYb5BTcVb-Uum5c58Llh0Au-wmtiUbY1W5lzjrswf4tPFchVGgrAX_OeGRmJ92JlTHjMFlG9ATyz8QCYoYNbjvENmi_B54j2hpdsw5HEmROhqxQJvQ8dtxBih2RzmYiVk4_EHWdIYar1WwyLG1pTylhceZsZIEEIFcH_VH-z_aA32HCQAt6U0Wk820YEPlYOBwUqpTTtNj2J5T5r-ML6bXsqHDwshVvFBt_v8_Ly7omIRztkLrIS70IvdFQhBpT_Fjz7nn1BrdwL_HT1MjvFfqaibaRqr5GjcVb9wQoh8qLcyM4a1IvLvE8GyAiD15YtqWIf4gcifYxFlz6mu7oaycReJk72IzOLDl1CoMnyZ_RjPsNoxeEckPrNlfLSGoX2G8c1WBintGkTPmFBeV5bJMsAem9OE4_tfEsp99JRe-e2lykYHYbTMd7egCjwFVy2l8Xa9wpZNLi9TH0itEt_L_CJ9KRPOk6Jqx5S7saycH7g88WDDlU5tue9xeo8VwCQ6bpa8cuq6pCk39GEMNZLjG2pwEUCHpA6k5D_z8J5yO9NSJNvLxVZW_KTG2IVkN8BwOoLo0VOOnRIAbGAFEJO-eQ1VM0-H_F7i-IEtUQamfOrBTNG9ENA3XeygbkHta1UwcugyHXPlUpIV5zylBLphEqQOUCIlZR6Z6b6dN7vXTJwazDCprGWuGJZvrHaYxn85d68LW5HWlV4AD_XmCu6yUlIu3vKxvw51py8rHuK8VcldRel7yas0WLCXF1fT95dzPZhVlnKx03hfZfl7OdQYLVgsAf4mPKpTlzCJK1msKH0vh5UGCwbz4r8Jf7MFFRAa6dywqvi9DFabLCgsyv8fHI5VDdKYJg0EZFyjIhd8lEIScRGsEiHrcthZ-rH7G0bWePgsIyZ5Yn56dnZ6fHvx9TSNrssikrffgmR5jwSpf4u91ozJppA4uY_V42Hnq8-eZUVOgDqfx9guzukqLrUUo5a05hxXVL02iTr38yPsal0FQK_p9IVFOA18gy1A5DNtvfLyhkopg5i4wt2IThueDusVqUzIMcTyKmWmYUoexOu14Nm4tjlYWCML-xjKtZbT0gYmBAan4Oj-3Hdx61ff5RjKKlQNL_lZhra_0zSOXoeMPnQKVKFeWE16Oum0tIZVeeyuZVWV6sVPmEu1bVeFeuE8CxsG55gKr9aSo2o0fQkD6eQwaCY-x6SLtmdPOcsheoXXYsGidMuq03QFc1QGqR04aluo1VNC1HAlD6s0DGGZXlQdyGjagGU1gyY9pNCNdr9-yG4eJWj6o4zRq1JJOC2HaUKvphvSXLamC1RpTUuydL6mEWlxzUCRc_DkKfQ9ldTVDJktWN2kEbqP71cjM9XvV7Odun6_xjNO40dtf6elevE74WOAVKFFBWRGSnBgvU8Djq_3acBs5PLN0tPtUKSQndYHIXnetFI4K60b-2k69c0aVNL3zeIyJ_1mabkAnLA5puNrV4AcUzM4RBKcABmiZmAYqpLVqp5Fita10qXWwsqWttaoRnd6HaRuAlCQBkWwmJ_XhItmmvLTmHNGOV4UDPn7FL669vIeZXienKxo4GXqrquC9KIfDNkLRQw65QnACR5bv5fDgC3XFYr09Rp3s22dPBvAjVZ6ojETsClbsYCJCIKSP8Jw-ethZ2-wO7L2B45j9fp7Q0u9v8yzsTLBDHH4iQ-dGUknzIwj8D-HnU9W39kd7Vk9xxrtj_bTMxC5EU6T3_ic5771-pKYqftw3xhdhYGUUHyp_SZoyfby6n60ep5wgTfOyjnuKZSI9QG5-3Lxy93pziwJ4hX3A9hc70yiiK7JUeI-cviVxg4HxOnbO5eMPiTsgJzQ54CEcwJDlJzDXnsnPeA5IOB_BKKdA2IRPMn9kdgED1x_JA7Jj0Rr0E6KtmvRdoq2jHTbW7qtWrSzpds2Qtt1uqWrHJQwWX30WGcLa9dgi5qa6y0YbNbrGNTB3sKW9arUBPNILmTtnNOYgFcWr9C_C-RG0WgnPe4BM70daXDKfj8gg8EObKu578IsjDo_w3ouYiL3xgfkhkbReufPCD9GOOjtDr7_0-r1Pjm93r9-wAOciNEYDyKUd5OpTGzu_JkOmAPr-0frByJCks6nsllEhfG4tBVI2xjpfP9omyH7xsjB94-OGXJojLS2rWPX6trumCGdbZa0yL6xzoGxzqFxi6xt67kb6wiwW8Cddtr72w2shw_aVWbYTvsItCNajj-c-ynnikeVLC2Qe9BKM-Q-VMEMafWMlVqWuVbbuFGjKqVyCFU03xC5X2W9EonNN4VaVUxVQ21j6KgKWThMBQd2C_h-O-3IhtUGb7WrDvJioB9PEK5CT37uRuQ6c9iBhSYLs9IzBi3CbkQ4jYh-I2LQiBg2IkaNiL1GxH4jwuo1Q5pZtZpptZp5tZqJtZqZtZqptZq5tZrJtZrZtZvZtQ18tpldu5ldu5ldu5ldu5ldu5ldu5ldu5ldp5ldp5ldx2BKaGbXaWbXaWbXaWbXaWbXyT6AkKe--R4V71vpt7KbV7F4KIgPMjf3d9NLvFuljlM_8_AJ80FYpO7VdesFlBlitRexW4hMcX1wWggchaF4SzPI7Blv-xrLTZYJZ6JtS9o0XWaCW7VdSbS38ZY-bMvXEeNt2JKZ7lYVO2d82b5DrFau5a1JdrDUsiWvO0UNYXVBAtNm1IPxiymzbwwDo1jl1WROS96bCIO5_5Bmt9SPNL8l5fM3RPiCMzyMlbc4Nwd_-f6Em8QiXMJMExf3LX6FppEFbP-JS4N_QEfH_xbknhGGn5F4O7G6f-oxyonT-4EsQ4hsvdL1hi0LMBn5mFKUCcU83Dt9Ab1JBPPSfRhyRoM0GdeoYbbAC7meRu6GU5ctYKvBolSaSSH1twKy-yGjXq9BYOODgUysSShvXHYbJBPcHw6a7JX-1kAmVSMjSZjh5Yz41a0XvQ14075muHFpLyVj_EJgz9bjl_mfTcCP-lnEPNmwY7xtNGN8XmrgwKCF2502MO61G0zsZ2KOqVRre_mpck5Ov8nY5rdTrfwK_XhbzNkbGhDZio7s-4RCwu4ZOFZr8nCcIBOwAMkPfrfHQJ3VkqPhHar1Xczw60UWCL42GkWx_-Dz67k8YwTD8qDUQGzmhvIMpOVojYpbZXkvNNGTrUu5a_WGjgkheFgZtGRD9bv6mi_kXIaq5SnWoPtNXex4gXfxqgkcd_NVT51ByV8_7Yy7r_6-zv8AldI0Og==

@Paliak Paliak added the bug: behaviour Behavioral differences label May 7, 2025
@Paliak Paliak closed this May 7, 2025
@Paliak
Copy link
Copy Markdown
Contributor Author

Paliak commented May 7, 2025

Turns out the way this works currently is most likely correct.

@LocalIdentity LocalIdentity reopened this May 7, 2025
Copy link
Copy Markdown
Contributor

@LocalIdentity LocalIdentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I had checked before I forgot to update my game files. GGG appears to have added the area damage flag in 0.2.0f

@LocalIdentity LocalIdentity merged commit 73b69e6 into PathOfBuildingCommunity:dev May 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviour Behavioral differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Area of Effect Damage not scaling on Concoction skills

2 participants