Skip to content

fixes issue where CI wasn't correctly overriding life before conversions.#1191

Closed
dhope1106 wants to merge 0 commit intoPathOfBuildingCommunity:devfrom
dhope1106:dev
Closed

fixes issue where CI wasn't correctly overriding life before conversions.#1191
dhope1106 wants to merge 0 commit intoPathOfBuildingCommunity:devfrom
dhope1106:dev

Conversation

@dhope1106
Copy link
Copy Markdown
Contributor

@dhope1106 dhope1106 commented Aug 26, 2025

Fixes item from https://docs.google.com/spreadsheets/d/1lSQemeNm8ZKXOih1QOqLb_ldzO0v373X3q7-ySDnrMU/edit?gid=588477260#gid=588477260. On the "Other" tab named "Update CI Handling".

This fix addresses only the CI/Life issue not the Blood Magic/Mana issue. Life and mana are handled in different parts of the code.

Description of the problem being solved:

In a situation where you are using Chaos Inoculation and are converting life to energy shield, life was being converted based on life prior to the Chaos Inoculation override. This lead to significantly increased ES.

Steps taken to verify a working solution:

  • created a POB with both Chaos Inoculation and using Ghostwrithe
  • created a POB with Chaos Inoculation and added "20% of life converted to energy shield" as a custom modifier
  • I verified in game that the amount of ES was consistent with the fixes in POB2

Link to a build that showcases this PR:

https://pobb.in/EQeiz1hHOyxQ

Before screenshot:

image

After screenshot:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants