Fix CI not working correctly with Ghostwrithe#1210
Merged
LocalIdentity merged 4 commits intoPathOfBuildingCommunity:devfrom Aug 29, 2025
Merged
Fix CI not working correctly with Ghostwrithe#1210LocalIdentity merged 4 commits intoPathOfBuildingCommunity:devfrom
LocalIdentity merged 4 commits intoPathOfBuildingCommunity:devfrom
Conversation
… conversions (like conversion to ES from GhostWrithe) occur
…. Example is Ghostwrite (#% of Maximum Life is converted to Energy Shield), and a similar issue regarding Mana and Blood Magic
Nightblade
added
bug: calculation
LocalIdentity
changed the title
LocalIdentity
added
bug: calculation
LocalIdentity
approved these changes
Aug 29, 2025
Tonkat
pushed a commit
to Tonkat/PathOfBuilding-PoE2
that referenced
this pull request
Sep 1, 2025
…y#1210) * changes to fix issue where CI wasn't correctly overriding life before conversions (like conversion to ES from GhostWrithe) occur * Fixes issue where life was being converted prior to CI life reduction. Example is Ghostwrite (#% of Maximum Life is converted to Energy Shield), and a similar issue regarding Mana and Blood Magic * removed irrelevant change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes item from https://docs.google.com/spreadsheets/d/1lSQemeNm8ZKXOih1QOqLb_ldzO0v373X3q7-ySDnrMU/edit?gid=588477260#gid=588477260. On the "Other" tab named "Update CI Handling".
This fix addresses only the CI/Life issue not the Blood Magic/Mana issue. Life and mana are handled in different parts of the code.
Description of the problem being solved:
In a situation where you are using Chaos Inoculation and are converting life to energy shield, life was being converted based on life prior to the Chaos Inoculation override. This lead to significantly increased ES.
Steps taken to verify a working solution:
created a POB with both Chaos Inoculation and using Ghostwrithe
created a POB with Chaos Inoculation and added "20% of life converted to energy shield" as a custom modifier
I verified in game that the amount of ES was consistent with the fixes in POB2
Link to a build that showcases this PR:
https://pobb.in/EQeiz1hHOyxQ
Before screenshot:
After screenshot:
