Resume failed update feature#1226
Merged
LocalIdentity merged 5 commits intodevfrom Aug 29, 2025
Merged
Conversation
-use GetScriptPath and GetRuntimePath to assign vas in UpdateCheck.lua -fixes flashing command prompt caused by io.popen -fall back to "." if unable to determine paths
-preserves original definition, prevents global namespace pollution
Tonkat
pushed a commit
to Tonkat/PathOfBuilding-PoE2
that referenced
this pull request
Sep 1, 2025
* [PATCH 1/2] Resume failed download * [PATCH 2/2] Get proper local directory * [PATCH 1/2] Fix flashing command prompt during update check -use GetScriptPath and GetRuntimePath to assign vas in UpdateCheck.lua -fixes flashing command prompt caused by io.popen -fall back to "." if unable to determine paths * [PATCH 2/2] Define scriptPath and runtimePath as local -preserves original definition, prevents global namespace pollution * Use local script path --------- Co-authored-by: Craig Citro <craig@citro.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy of PathOfBuildingCommunity/PathOfBuilding#8469
Includes PathOfBuildingCommunity/PathOfBuilding#8721