Fixed directory name case inconsistencies#633
Closed
atty303 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Closed
Fixed directory name case inconsistencies#633atty303 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
atty303 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
Unable to read StatDescription on case-sensitive systems such as Linux
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Unable to read StatDescription on case-sensitive systems such as Linux. My case was an error when I tried to add Skill in pob-web.
The directory is capitalized as
src/Data/StatDescriptions/Specific_Skill_Stat_Descriptions, but the directory name in the skill dataparentis lower-cased.PathOfBuilding-PoE2/src/Data/StatDescriptions/Specific_Skill_Stat_Descriptions/herald_of_thunder_statset_1.lua
Line 89 in 7cfb8bd
I would like to unify this with lower case or capital case.
parentof the skill data in ExportWhich would you prefer?
Steps taken to verify a working solution: