Skip to content

Fixed directory name case inconsistencies#633

Closed
atty303 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
atty303:fix-case
Closed

Fixed directory name case inconsistencies#633
atty303 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
atty303:fix-case

Conversation

@atty303
Copy link
Copy Markdown

@atty303 atty303 commented Jan 27, 2025

Description of the problem being solved:

Unable to read StatDescription on case-sensitive systems such as Linux. My case was an error when I tried to add Skill in pob-web.

image

The directory is capitalized as src/Data/StatDescriptions/Specific_Skill_Stat_Descriptions, but the directory name in the skill data parent is lower-cased.

parent="specific_skill_stat_descriptions/herald_of_thunder_statset_0"

I would like to unify this with lower case or capital case.

  • To unify to a capital case:
    • You need to patch the parent of the skill data in Export
  • To unify to a lower case (this PR):
    • Consistency with other directories is a concern.

Which would you prefer?

Steps taken to verify a working solution:

  • This PR will allow you to add your skills in pob-web.
  • Windows build still works.

Unable to read StatDescription on case-sensitive systems such as Linux
@Paliak Paliak added the bug: accuracy Wording differences label Apr 4, 2025
@atty303 atty303 closed this Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: accuracy Wording differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants