Skip to content

introduce pat-update event factory, use it in basepattern, emit after validation checks. #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/core/basepattern.js
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,16 @@ class BasePattern {
// Extend this method in your pattern.
}

emit_update(action = undefined, options = {}) {
options = {
pattern: this.name,
dom: this.el,
action: action,
...options,
}
this.el.dispatchEvent(events.update_event(options));
}

/**
* Listen to an event on the element only once.
*
Expand Down
25 changes: 25 additions & 0 deletions src/core/basepattern.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -364,4 +364,29 @@ describe("Basepattern class tests", function () {
// If test reaches this expect statement, the init event catched.
expect(true).toBe(true);
});

it("7 - Emit update event.", async function () {
const events = (await import("./events")).default;
class Pat extends BasePattern {
static name = "example";
static trigger = ".example";
}

const el = document.createElement("div");
el.classList.add("example");

const pat = new Pat(el);
await events.await_pattern_init(pat);

let event;
el.addEventListener("pat-update", (e) => {
event = e;
});

pat.emit_update("test");

expect(event.detail.pattern).toBe("example");
expect(event.detail.dom).toBe(el);
expect(event.detail.action).toBe("test");
});
});
23 changes: 23 additions & 0 deletions src/core/events.js
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,28 @@ const generic_event = (name) => {
});
};


/** Patternslib specifc event factories
*/

class UpdateEvent extends CustomEvent {
constructor(options) {
super("pat-update", {
bubbles: true,
cancelable: true,
detail: options
});
}
}

const update_event = (options) => {
return new UpdateEvent(options);
}


/** Web API event factories
*/

const blur_event = () => {
return new Event("blur", {
bubbles: false,
Expand Down Expand Up @@ -266,6 +288,7 @@ export default {
await_event: await_event,
await_pattern_init: await_pattern_init,
generic_event: generic_event,
update_event: update_event,
blur_event: blur_event,
click_event: click_event,
change_event: change_event,
Expand Down
20 changes: 20 additions & 0 deletions src/core/events.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,26 @@ describe("core.events tests", () => {
expect(catched).toBe("outer");
});

it("update event", async () => {
outer.addEventListener("pat-update", () => {
catched = "outer";
});
inner.dispatchEvent(events.update_event());
await utils.timeout(1);
expect(catched).toBe("outer");
});

it("update event with data", async () => {
let event;
outer.addEventListener("pat-update", (e) => {
event = e;
});
const data = {"foo": "bar"};
inner.dispatchEvent(events.update_event(data));
await utils.timeout(1);
expect(event.detail).toBe(data);
});

it("blur event", async () => {
outer.addEventListener("blur", () => {
catched = "outer";
Expand Down
46 changes: 30 additions & 16 deletions src/pat/validation/validation.js
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ class Pattern extends BasePattern {
}

// In any case, clear the custom validity first.
this.set_validity({ input: input, msg: "" });
this.set_error({ input: input, msg: "", skip_event: true });
const validity_state = input.validity;

if (event?.submitter?.hasAttribute("formnovalidate")) {
Expand Down Expand Up @@ -148,7 +148,7 @@ class Pattern extends BasePattern {
const message =
input_options.message.equality ||
`The value is not equal to %{attribute}`;
this.set_validity({
this.set_error({
input: input,
msg: message,
attribute: input_options.equality,
Expand Down Expand Up @@ -216,7 +216,7 @@ class Pattern extends BasePattern {
);
msg_attr = msg_attr || not_after_el.name;
}
this.set_validity({
this.set_error({
input: input,
msg: msg || msg_default_not_after,
attribute: msg_attr.trim(),
Expand All @@ -237,7 +237,7 @@ class Pattern extends BasePattern {
);
msg_attr = msg_attr || not_before_el.name;
}
this.set_validity({
this.set_error({
input: input,
msg: msg || msg_default_not_before,
attribute: msg_attr.trim(),
Expand Down Expand Up @@ -266,15 +266,15 @@ class Pattern extends BasePattern {
// Default error cases with custom messages.

if (validity_state.valueMissing && input_options.message.required) {
this.set_validity({ input: input, msg: input_options.message.required });
this.set_error({ input: input, msg: input_options.message.required });
} else if (validity_state.rangeUnderflow && input_options.message.min) {
this.set_validity({
this.set_error({
input: input,
msg: input_options.message.min,
min: input.getAttribute("min"),
});
} else if (validity_state.rangeOverflow && input_options.message.max) {
this.set_validity({
this.set_error({
input: input,
msg: input_options.message.max,
max: input.getAttribute("max"),
Expand All @@ -284,38 +284,43 @@ class Pattern extends BasePattern {
input.type === "number" &&
input_options.message.number
) {
this.set_validity({ input: input, msg: input_options.message.number });
this.set_error({ input: input, msg: input_options.message.number });
} else if (
validity_state.typeMismatch &&
input.type === "email" &&
input_options.message.email
) {
this.set_validity({ input: input, msg: input_options.message.email });
this.set_error({ input: input, msg: input_options.message.email });
} else if (
validity_state.rangeUnderflow &&
input.type === "date" &&
input_options.message.date
) {
this.set_validity({ input: input, msg: input_options.message.date });
this.set_error({ input: input, msg: input_options.message.date });
} else if (
validity_state.rangeOverflow &&
input.type === "date" &&
input_options.message.date
) {
this.set_validity({ input: input, msg: input_options.message.date });
this.set_error({ input: input, msg: input_options.message.date });
} else if (
validity_state.rangeUnderflow &&
input.type === "datetime" &&
input_options.message.datetime
) {
this.set_validity({ input: input, msg: input_options.message.datetime });
this.set_error({ input: input, msg: input_options.message.datetime });
} else if (
validity_state.rangeOverflow &&
input.type === "datetime" &&
input_options.message.datetime
) {
this.set_validity({ input: input, msg: input_options.message.datetime });
this.set_error({ input: input, msg: input_options.message.datetime });
} else {
// Still an error, but without customized messages.
// Call `emit_update` separately
this.emit_update("invalid");
}

}

if (event?.type === "submit") {
Expand All @@ -327,7 +332,7 @@ class Pattern extends BasePattern {
this.set_error_message(input);
}

set_validity({ input, msg, attribute = null, min = null, max = null }) {
set_error({ input, msg, attribute = null, min = null, max = null, skip_event = false }) {
// Replace some variables, as like validate.js
if (attribute) {
msg = msg.replace(/%{attribute}/g, attribute);
Expand All @@ -345,9 +350,13 @@ class Pattern extends BasePattern {
// Hidden inputs do not participate in validation but we need this
// (e.g. styled date input).
input[KEY_ERROR_MSG] = msg;

if (!skip_event) {
this.emit_update("invalid");
}
}

remove_error(input, all_of_group = false) {
remove_error(input, all_of_group = false, skip_event = false) {
// Remove error message and related referencesfrom input.

let inputs = [input];
Expand All @@ -370,10 +379,15 @@ class Pattern extends BasePattern {
}
}
}

if (!skip_event) {
this.emit_update("valid");
}
}

set_error_message(input) {
this.remove_error(input);
// First, remove the old error message.
this.remove_error(input, false, true);

// Do not set a error message for a input group like radio buttons or
// checkboxes where one has already been set.
Expand Down
35 changes: 35 additions & 0 deletions src/pat/validation/validation.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -503,6 +503,41 @@ describe("pat-validation", function () {
expect(el.querySelectorAll("em.warning").length).toBe(1);
});

it("1.21 - Emits an update event when the validation state changes", async function () {
document.body.innerHTML = `
<form class="pat-validation">
<input name="name" required>
</form>
`;
const el = document.querySelector(".pat-validation");
const inp = el.querySelector("[name=name]");

const instance = new Pattern(el);
await events.await_pattern_init(instance);

let event;
el.addEventListener("pat-update", (e) => {
event = e;
});

inp.value = "";
inp.dispatchEvent(events.change_event());
await utils.timeout(1); // wait a tick for async to settle.

expect(el.querySelectorAll("em.warning").length).toBe(1);
expect(event.detail.pattern).toBe("validation");
expect(event.detail.dom).toBe(el);
expect(event.detail.action).toBe("invalid");

inp.value = "okay";
inp.dispatchEvent(events.change_event());
await utils.timeout(1); // wait a tick for async to settle.

expect(event.detail.pattern).toBe("validation");
expect(event.detail.dom).toBe(el);
expect(event.detail.action).toBe("valid");
});

it("2.1 - validates required inputs", async function () {
document.body.innerHTML = `
<form class="pat-validation">
Expand Down