-
Notifications
You must be signed in to change notification settings - Fork 42
feat(pat-validation): Support definition of minimum or maximum number of selections. #1249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thet
wants to merge
12
commits into
master
Choose a base branch
from
validation-min-max
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47b56d1
to
86ee675
Compare
…ate of all siblings.
…of inputs with the same name.
Introduce event delegation and register input, change and focusout event handlers on the document level. This reduces the amount of registered event handlers which potentially improves performance and also supports dynamic forms where form elements can be added at any time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @cornae
we had the need to validate if at least one checkbox in a group of checkboxes was checked.
This was not yet supported by pat-validation nor by the HTML specficiation.
As a side note - required radio buttons are supported. A
required
attribute on one or all radio inputs in a group of radio inputs is supported by the HTML specification and validated by pat-validation.We were in need to quickly support that in one of our projects and I did a implementation which we deployed but still can change if there is anything to improve - behavior wise, parameter naming or whatever.
These parameters were added:
Note: this does not only work with checkboxes but with any kind of input.
I recognized that we can use the same name for any kind of input - any input, select or textarea. All of the values will be submitted to the server. Therefore this implementation is not only limited to checkboxes but any kind of input.
Along the way I did some other improvements:
The documentation is updated and extended.
pat-validation now fully supports input elements outside the form itself, e.g.:
pat-validation also fully supports dynamic forms without re-initalizing or sending a special "pat-update" event. You can add form elements even without pat-inject and it should immediately take part in validation.
And a important one:
For multiple input elements with the same name the error message was shown wether immediately after the last input which the user interacted with or the the end of a
fieldset.checkbox
element.I have changed that, so that the error message is just shown after the last input with the same name.
We needed that also for our project and I believe it's better because it works just out of the box and there is no need to add a
fieldset.checkbox
element.