Add type hints and make mypy compatible #192
Conversation
enable mypy check enable test and linting check on pull request drop python2 support Closes PaulSchweizer#189
jonassorgenfrei
force-pushed
the
189-type-hints
branch
from
3efadd0 to
bd6af40
Compare
.github/workflows/pylint.yml
Outdated
| @@ -1,6 +1,6 @@ | |||
| name: Pylint | |||
|
|
|||
| on: [push] | |||
There was a problem hiding this comment.
Doesn't push also "include" pull_request?
There was a problem hiding this comment.
for pull_request it also runs when a PR is opened, synchronized (new commits pushed to the PR’s branch), or reopened.
There was a problem hiding this comment.
Usually it's best practice to specify which branches should be the target for both pushes and pull requests. Otherwise any branch will have the CI run which usually is not what people want to have.
I'd generally speaking also add a workflow_dispatch so one can manually run the CI at any branch they would like.
It would look like this
https://github.com/grische/extremeflash/blob/9bcdda9b35f3a47f67a35e60711df934fec68fd1/.github/workflows/python-package.yml#L4-L11
189 type hints additions
There was a problem hiding this comment.
@PaulSchweizer i needed to adjust 604 and 628 because of mypy issue
Co-authored-by: Grische <[email protected]>
|
added a mypy python version matrix |
3 participants
enable mypy check
enable test and linting check on pull request
drop python2 support
Closes #189