Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Microsoft Stream video component #223

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gaelhameon
Copy link

Hi !
Thanks for this project ! I'd like to use it to embed videos hosted on Microsoft Stream so I added a component.
Right now, I only created the Video component, but there are other objects in Microsoft Stream that can be embedded, like channels and groups, so I tried using a folder structure and naming convention that would make it easy to add those in the future.
And I haven't looked into it too much yet, but I think it's possible to embed media from other Microsoft products too, so I created a specific folder for Stream.

I havent found any public stream videos and I don't think such a thing exists. I've limited the integration tests to checking if the sign in buttons appear. Locally, it works fine after that when I log in to stream with my company's credentials.

cy.getIframeBody().then((data) => {
console.log({data});
});
cy.getIframeBody().find('#streamLoading');
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the .should('not.be.undefined'); used in other components' tests.
It seems to make tests pass when they shouldn't whereas simply stopping after the find() works well.

For an example, I modified the youtube tests on this branch:
https://github.com/gaelhameon/mdx-embed/blob/wip/questions/cypress/integration/youtube.spec.js

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@08412dc). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #223   +/-   ##
=======================================
  Coverage        ?   94.21%           
=======================================
  Files           ?       94           
  Lines           ?      795           
  Branches        ?      149           
=======================================
  Hits            ?      749           
  Misses          ?       11           
  Partials        ?       35           
Impacted Files Coverage Δ
...ed/src/components/mdx-embed-provider/components.ts 100.00% <100.00%> (ø)
...rc/components/microsoft/stream/ms-stream-video.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08412dc...7b33611. Read the comment docs.

@PaulieScanlon PaulieScanlon force-pushed the main branch 2 times, most recently from d5003a6 to 63fffdb Compare September 9, 2021 17:45
@PaulieScanlon PaulieScanlon force-pushed the main branch 9 times, most recently from a78cbb9 to b6f1380 Compare February 6, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants