feat: add Microsoft Stream video component #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelhameon
commented
Apr 18, 2021
| cy.getIframeBody().then((data) => { | ||
| console.log({data}); | ||
| }); | ||
| cy.getIframeBody().find('#streamLoading'); |
There was a problem hiding this comment.
I removed the .should('not.be.undefined'); used in other components' tests.
It seems to make tests pass when they shouldn't whereas simply stopping after the find() works well.
For an example, I modified the youtube tests on this branch:
https://github.com/gaelhameon/mdx-embed/blob/wip/questions/cypress/integration/youtube.spec.js
Codecov Report
@@ Coverage Diff @@
## main #223 +/- ##
=======================================
Coverage ? 94.21%
=======================================
Files ? 94
Lines ? 795
Branches ? 149
=======================================
Hits ? 749
Misses ? 11
Partials ? 35
Continue to review full report at Codecov.
|
PaulieScanlon
force-pushed
the
main
branch
2 times, most recently
from
d5003a6 to
63fffdb
Compare
PaulieScanlon
force-pushed
the
main
branch
9 times, most recently
from
a78cbb9 to
b6f1380
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
Thanks for this project ! I'd like to use it to embed videos hosted on Microsoft Stream so I added a component.
Right now, I only created the Video component, but there are other objects in Microsoft Stream that can be embedded, like channels and groups, so I tried using a folder structure and naming convention that would make it easy to add those in the future.
And I haven't looked into it too much yet, but I think it's possible to embed media from other Microsoft products too, so I created a specific folder for Stream.
I havent found any public stream videos and I don't think such a thing exists. I've limited the integration tests to checking if the sign in buttons appear. Locally, it works fine after that when I log in to stream with my company's credentials.