Classify missing table on PG #2906
Merged
+21
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
approved these changes
May 5, 2025
There was a problem hiding this comment.
@iamKunalGupta do unknown classifications get passed through as an error to slack without sending out notifications?
heavycrystal
approved these changes
May 7, 2025
iamKunalGupta
approved these changes
May 12, 2025
| @@ -110,6 +108,9 @@ func (c *PostgresConnector) getRelIDForTable(ctx context.Context, schemaTable *u | |||
| ON n.oid = c.relnamespace WHERE n.nspname=$1 AND c.relname=$2`, | |||
| schemaTable.Schema, schemaTable.Table).Scan(&relID) | |||
| if err != nil { | |||
| if errors.Is(err, pgx.ErrNoRows) { | |||
| return 0, shared.ErrTableDoesNotExist | |||
There was a problem hiding this comment.
do we want to include table name in the error information?
Also maybe we should wrap the original error as well
There was a problem hiding this comment.
original error is already known to be pgx.ErrNoRows, not sure if I'm following
Yes, anything unknown is auto sent to us, without sending out to customer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Postgres table is dropped, then we get a
no rows in result seterror when a schema change (RelationMessage) is encountered.This PR catches this specific error case and classifies it