Skip to content

[mysql] general fixes #2924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 13, 2025
Merged

[mysql] general fixes #2924

merged 6 commits into from
May 13, 2025

Conversation

heavycrystal
Copy link
Contributor

@heavycrystal heavycrystal commented May 9, 2025

  1. MySQL connections were setting compression unconditionally, respect setting instead
  2. remove unused Snowflake SQL
  3. remove binlog/replication validation from peer creation so we can do initial load only mirrors for MySQL
  4. make binlog/replication validation during mirror creation conditional on initial load only
  5. change double quotes to backticks for statements we run on MySQL during initial load, brings us closer to supporting Vitess which can't handle ANSI_QUOTES

@heavycrystal heavycrystal requested review from serprex and Copilot May 9, 2025 20:03
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements several MySQL-related fixes and cleanups while also removing unused Snowflake SQL code. Key changes include conditionally setting compression for MySQL connections, revising replication connectivity checks to handle initial load only mirrors, and updating table quoting to backticks for improved Vitess support.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
flow/workflows/snapshot_flow.go Updates table quoting logic based on peer database type to support Vitess
flow/connectors/snowflake/snowflake.go Removes unused SQL constants for Snowflake
flow/connectors/mysql/validate.go Adjusts replication connectivity checks and bypasses them when initial snapshot is used
flow/connectors/mysql/qrep.go Improves partition query construction by using a parsed MySQL table identifier
flow/connectors/mysql/mysql.go Makes setting the CLIENT_COMPRESS capability conditional on the compression configuration

@heavycrystal heavycrystal merged commit 3e60cb0 into main May 13, 2025
9 checks passed
@heavycrystal heavycrystal deleted the mysql-touchups-1 branch May 13, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants