Skip to content

engines: ReplicatedReplacingMergeTree, ReplicatedMergeTree#2949

Merged
serprex merged 3 commits into
mainfrom
rmt
May 28, 2025
Merged

engines: ReplicatedReplacingMergeTree, ReplicatedMergeTree#2949
serprex merged 3 commits into
mainfrom
rmt

Conversation

@serprex

@serprex serprex commented May 19, 2025

Copy link
Copy Markdown
Member

No description provided.

Comment thread flow/connectors/clickhouse/normalize.go Outdated
@serprex serprex force-pushed the rmt branch 2 times, most recently from 9889a05 to b4af056 Compare May 19, 2025 19:24
Comment thread ui/app/mirrors/create/cdc/schemabox.tsx Outdated
Comment on lines 249 to 252

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking whether we should add a tooltip for new users.
Maybe simply saying that works with ch cloud and what works with oss clusters

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mirror validation could check for host being CHC

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be possible with CheckIfClickHouseCloudHasSharedMergeTreeEnabled

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That only runs when we're in clickpipes. Validation here is for OSS peerdb users with CHC destination

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I mean we can use that function outside of current codepath to get if a service is SMT which should mean we disable these engines

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for now we can omit this, people using CHC should know this engine doesn't apply to them

Comment thread flow/connectors/clickhouse/normalize.go Outdated

@heavycrystal heavycrystal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as an experiment

@serprex serprex enabled auto-merge (squash) May 28, 2025 13:42
@serprex serprex merged commit e63b71d into main May 28, 2025
18 checks passed
@serprex serprex deleted the rmt branch May 28, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants