add frontend for fetching type conversion#2987
Merged
Merged
Conversation
jgao54
force-pushed
the
type-conversion-frontend
branch
from
17e90ff to
007c8fb
Compare
jgao54
force-pushed
the
type-conversion-frontend
branch
from
007c8fb to
dc7d7ca
Compare
jgao54
force-pushed
the
type-conversion-frontend
branch
from
dc7d7ca to
affb62c
Compare
jgao54
commented
May 30, 2025
Contributor
Author
There was a problem hiding this comment.
note: the maxHeight was blocking the dropdown lists from being fully visible, so removed it here.
jgao54
force-pushed
the
type-conversion-frontend
branch
from
affb62c to
9fbf048
Compare
serprex
reviewed
May 30, 2025
Comment on lines
56
to
63
serprex
reviewed
May 30, 2025
Member
There was a problem hiding this comment.
Suggested change
| return destinationTypeMapping[col] || []; | |
| return destinationTypeMapping[col] ?? []; |
& elsewhere
serprex
reviewed
May 30, 2025
Member
There was a problem hiding this comment.
this should be fixed (potentially split out as separate PR)
Contributor
Author
There was a problem hiding this comment.
Fixed with the useMemo trick.
Amogh-Bharadwaj
approved these changes
May 30, 2025
jgao54
force-pushed
the
type-conversion-api
branch
from
a2f40a6 to
b484551
Compare
jgao54
added a commit
that referenced
this pull request
May 30, 2025
Implement the backend to support [type conversion frontend](#2987)
jgao54
force-pushed
the
type-conversion-frontend
branch
from
b988a83 to
319dbe7
Compare
This was referenced Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create frontend for custom column type conversion..
It creates a dropdown of possible conversions determined by the backend. Right now only numeric -> string is supported.
If there are no available conversion, the option for
use custom column destination typewill be hidden.Test: locally created a table that contains column with numeric type, create ClickPipe via UI, and see CH table get created with String type.