[mysql] more logs and some changes in ctx handling#2988
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances logging around timeout handling in PullRecords and refactors column lookup for CDC events.
- Introduces an
overtimeflag to defer timeout exit until after a transaction ends, with adjusted context resets and logging. - Replaces manual loop for finding schema columns with
slices.IndexFuncfor clearer lookup logic.
Comments suppressed due to low confidence (1)
flow/connectors/mysql/cdc.go:346
- [nitpick] The variable name
overtimeis ambiguous; consider renaming it to something more descriptive liketxTimeoutTriggeredto clarify its purpose.
// set when a tx is preventing us from respecting the timeout, immediately exit after we see inTx false
serprex
reviewed
May 29, 2025
serprex
reviewed
May 29, 2025
Contributor
Author
|
not sure how to fix lints |
serprex
reviewed
May 29, 2025
serprex
reviewed
May 29, 2025
heavycrystal
force-pushed
the
feat/mysql-ctx-tuning
branch
from
c70d405 to
e714af0
Compare
serprex
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.