Skip to content

slot info: don't poll for completed/terminated mirrors #2990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serprex merged 2 commits into from
May 30, 2025
Merged

slot info: don't poll for completed/terminated mirrors #2990

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
537d570
slot info: don't poll for completed/terminated mirrors
serprex May 29, 2025
15e1eeb
Merge branch 'main' into lees-slot-polling
serprex May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions flow/activities/flowable.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,8 +749,7 @@ func (a *FlowableActivity) RecordSlotSizes(ctx context.Context) error {
}

var config protos.FlowConnectionConfigs
err = proto.Unmarshal(configProto, &config)
if err != nil {
if err := proto.Unmarshal(configProto, &config); err != nil {
return nil, err
}

Expand Down Expand Up @@ -816,6 +815,12 @@ func (a *FlowableActivity) RecordSlotSizes(ctx context.Context) error {
attribute.String(otel_metrics.FlowStatusKey, status.String()),
attribute.Bool(otel_metrics.IsFlowActiveKey, info.isActive),
)))

if flowMetadata.Status == protos.FlowStatus_STATUS_COMPLETED ||
flowMetadata.Status == protos.FlowStatus_STATUS_TERMINATED {
Comment on lines +819 to +820

@iamKunalGupta iamKunalGupta May 29, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this will be populated, on phone rn. There's also status variable we are using above

return
}

srcConn, err := connectors.GetByNameAs[connectors.CDCPullConnector](ctx, nil, a.CatalogPool, info.config.SourceName)
if err != nil {
if !errors.Is(err, errors.ErrUnsupported) {
Expand Down