Skip to content

fix(e2e): use CI_MYSQL_VERSION as MySQL peer name #4183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ilidemi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(e2e): use CI_MYSQL_VERSION as MySQL peer name #4183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e7d54b
fix(e2e): use CI_MYSQL_VERSION as MySQL peer name to avoid collisions
ilidemi Apr 16, 2026
8a449a3
fix(e2e): use dynamic peer name in RDS binlog validation test assertions
github-actions[bot] Apr 16, 2026
74e7e5d
fix(e2e): always clean up mysql.rds_configuration table via t.Cleanup
github-actions[bot] Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flow/e2e/mysql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ func (s *MySqlSource) GeneratePeer(t *testing.T) *protos.Peer {
t.Helper()

peer := &protos.Peer{
Name: "mysql",
Name: os.Getenv("CI_MYSQL_VERSION"),
Type: protos.DBType_MYSQL,
Config: &protos.Peer_MysqlConfig{
MysqlConfig: s.Config,
Expand Down
11 changes: 7 additions & 4 deletions flow/e2e/mysql_rds_binlog_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,11 @@ func TestMySQLRDSBinlog(t *testing.T) {
}

func (s MySQLRDSBinlogAPITestSuite) TestMySQLRDSBinlogValidation() {
// Register cleanup before creating the table so it is always dropped even if the test fails early.

@pfcoperez pfcoperez Apr 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't debugged the issues myself, I just played the meat bot a bit. I don't think the AI fixes are enough, this requires human intervention. Leaving the two claude comments in the branch from now for @ilidemi to take a peek at its proposals.

s.t.Cleanup(func() {
_ = s.source.Exec(context.Background(), "DROP TABLE IF EXISTS mysql.rds_configuration")
})

require.NoError(s.t, s.source.Exec(s.t.Context(),
fmt.Sprintf("CREATE TABLE %s(id int primary key, val text)", AttachSchema(s, "valid"))))

Expand All @@ -92,7 +97,7 @@ func (s MySQLRDSBinlogAPITestSuite) TestMySQLRDSBinlogValidation() {
st, ok := status.FromError(err)
require.True(s.t, ok)
require.Equal(s.t, codes.FailedPrecondition, st.Code())
require.Equal(s.t, "failed to validate source connector mysql: binlog configuration error: "+
require.Equal(s.t, "failed to validate source connector "+flowConnConfig.SourceName+": binlog configuration error: "+
"RDS/Aurora setting 'binlog retention hours' should be at least 24, currently unset", st.Message())

require.NoError(s.t, s.source.Exec(s.t.Context(), "UPDATE mysql.rds_configuration SET value = '1' WHERE name = 'binlog retention hours'"))
Expand All @@ -102,13 +107,11 @@ func (s MySQLRDSBinlogAPITestSuite) TestMySQLRDSBinlogValidation() {
st, ok = status.FromError(err)
require.True(s.t, ok)
require.Equal(s.t, codes.FailedPrecondition, st.Code())
require.Equal(s.t, "failed to validate source connector mysql: binlog configuration error: "+
require.Equal(s.t, "failed to validate source connector "+flowConnConfig.SourceName+": binlog configuration error: "+
"RDS/Aurora setting 'binlog retention hours' should be at least 24, currently 1", st.Message())

require.NoError(s.t, s.source.Exec(s.t.Context(), "UPDATE mysql.rds_configuration SET value = '24' WHERE name = 'binlog retention hours';"))
res, err = s.ValidateCDCMirror(s.t.Context(), &protos.CreateCDCFlowRequest{ConnectionConfigs: flowConnConfig})
require.NoError(s.t, err)
require.NotNil(s.t, res)

require.NoError(s.t, s.source.Exec(s.t.Context(), "DROP TABLE IF EXISTS mysql.rds_configuration;"))
}