Skip to content

Support empty GTID set #4190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilidemi merged 2 commits into from
Apr 20, 2026
Merged

Support empty GTID set #4190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc14788
Support empty GTID set
ilidemi Apr 17, 2026
f01f8c2
Fix the other test
ilidemi Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions flow/connectors/mysql/replication_mechanism.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@ type parsedReplicationOffset struct {
}

func parseReplicationOffsetText(flavor string, offsetText string) (parsedReplicationOffset, error) {
if offsetText == "" {
return parsedReplicationOffset{}, nil
}

if rest, isFilePos := strings.CutPrefix(offsetText, "!f:"); isFilePos {
comma := strings.LastIndexByte(rest, ',')
if comma == -1 {
Expand Down
16 changes: 9 additions & 7 deletions flow/connectors/mysql/replication_mechanism_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,6 @@ import (
)

func TestParseReplicationOffsetText(t *testing.T) {
t.Run("empty", func(t *testing.T) {
parsedOffset, err := parseReplicationOffsetText("mysql", "")
require.NoError(t, err)
require.Equal(t, parsedReplicationOffset{}, parsedOffset)
})

t.Run("filepos", func(t *testing.T) {
parsedOffset, err := parseReplicationOffsetText("mysql", "!f:mysql-bin.000001,4d2")
require.NoError(t, err)
Expand All @@ -42,6 +36,14 @@ func TestParseReplicationOffsetText(t *testing.T) {
require.Equal(t, mysql.Position{}, parsedOffset.pos)
})

t.Run("empty", func(t *testing.T) {
parsedOffset, err := parseReplicationOffsetText("mysql", "")
require.NoError(t, err)
require.Equal(t, protos.MySqlReplicationMechanism_MYSQL_GTID.String(), parsedOffset.mechanism)
require.True(t, parsedOffset.gset.IsEmpty())
require.Equal(t, mysql.Position{}, parsedOffset.pos)
})

t.Run("invalid gtid", func(t *testing.T) {
_, err := parseReplicationOffsetText("mysql", "not-a-valid-offset")
require.ErrorContains(t, err, `failed to parse mysql offset text "not-a-valid-offset" as GTID set`)
Expand All @@ -64,7 +66,7 @@ func TestReplicationMechanismInUseFromOffsetText(t *testing.T) {
t.Run("empty", func(t *testing.T) {
mechanism, err := replicationMechanismInUseFromOffsetText("mysql", "")
require.NoError(t, err)
require.Empty(t, mechanism)
require.Equal(t, protos.MySqlReplicationMechanism_MYSQL_GTID.String(), mechanism)
})

t.Run("invalid", func(t *testing.T) {
Expand Down
Loading