feat: add second postgres instance for local testing#4281
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
🔄 Flaky Test DetectedAnalysis: The e2e test suite hit the 900-second global timeout (panic: test timed out after 15m0s), causing all in-progress tests to fail simultaneously — this is a timeout flake, not individual test logic bugs. ✅ Automatically retrying the workflow |
|
|
||
| postgres2: | ||
| container_name: peerdb-postgres2 | ||
| image: ${POSTGRES_IMAGE} |
There was a problem hiding this comment.
This is not a change request, I'd rather keep it simpler, but I wonder if you foresee needing to test different PG versions in source and destination.
There was a problem hiding this comment.
Yup that's a great shout @pfcoperez, would probably need to test PG16 to PG18 type mirrors
97d8180 to
a0e592e
Compare
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
🔄 Flaky Test DetectedAnalysis: The sole failing test (TestApiPg/TestPostgresDestinationValidation_WithExcludedColumns) hit SQLSTATE 57P01 ("terminating connection due to administrator command"), a transient PostgreSQL catalog shutdown caused by CI infrastructure — not a code defect. ✅ Automatically retrying the workflow |
For testing Postgres to Postgres mirrors, it would be good to have a second Postgres instance rather than have source and destination be same, for testing things like roles being copied over