Go Debug fallback ports collides with internal testing environments#4306
Merged
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
masterashu
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #4216, we exposed Go debug port for services in local dev-env.
The sample
.env.exampleports for these were carefully chosen so they wouldn't collide with ClickHouse internal testing tooling:peerdb/.env.example
Lines 69 to 71 in 1bce75b
But the fallback ports in Tiltfile didn't fall into the same range. This PR fixes the fallback ports.