mysql: add syncer.EventCacheCount setting#4413
Merged
Merged
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
jgao54
approved these changes
Jun 11, 2026
ilidemi
approved these changes
Jun 12, 2026
Co-authored-by: Ilia Demianenko <ilia.demianenko@clickhouse.com>
Co-authored-by: Ilia Demianenko <ilia.demianenko@clickhouse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We saw OOM errors on mysql pipes with large rows
go-mysql has internal events channel where it stores binlog events, that is where this allocation is coming from
It reads packet header that contains info about payload length in bytes and allocates memory for reading next events from the binlog
I think it's expected driver behavior and i'm not sure we should fix smth in that regard
But
There is one thing we could configure additionally to our PEERDB_CDC_CHANNEL_BUFFER_SIZE, we could set EventCacheCount on mysql syncer level.
This way we can cap how many events mysql driver loads in memory. (we can't control events' size though, so if the events themselves are big -> it won't really save us from OOM), by default it equals 10240
mysql go driver simply read packets over network and tries to push events to it's internal channel (which is capped by EventCacheCount):