maria: require resync on partial row events#4530
Merged
dtunikov merged 17 commits intoJul 8, 2026
Merged
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
- add metric to count unsupported event types
dtunikov
commented
Jul 2, 2026
dtunikov
commented
Jul 2, 2026
dtunikov
commented
Jul 2, 2026
dtunikov
commented
Jul 2, 2026
jgao54
reviewed
Jul 2, 2026
jgao54
reviewed
Jul 2, 2026
jgao54
approved these changes
Jul 2, 2026
jgao54
left a comment
Contributor
There was a problem hiding this comment.
a few nit comment but lgtm overall
ilidemi
reviewed
Jul 3, 2026
❌ 2 Tests Failed:
View the top 1 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
❌ Test FailureAnalysis: The PR's own new test Test_MariaDB_PartialRowEvent fails deterministically across all three matrix jobs (mysql-gtid/pos, MySQL 6.0/7.0/8.0) after ~190s, indicating a real bug in the PR's partial-row-event resync logic rather than a flaky failure. |
dtunikov
commented
Jul 3, 2026
dtunikov
commented
Jul 6, 2026
ilidemi
approved these changes
Jul 7, 2026
- add AdditionalAttributes to classified error
ilidemi
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't support partial row events. MariaDB 12.3+ emits those when payload size is bigger than
binlog_row_event_fragment_threshold(default 1Gb).This PR handles this event type and requires a resync.
In addition, it introduces
UnsupportedBinlogEventCounter(eventType)metric to keep track of skipped events.