mongoDB parallel snapshot follow-up#4531
Merged
Merged
Conversation
jgao54
commented
Jul 3, 2026
Comment on lines
-190
to
-191
| slog.String("minID", minVal), | ||
| slog.String("maxID", maxVal), |
Contributor
Author
There was a problem hiding this comment.
make sure we don't log _Ids in case of PII
jgao54
commented
Jul 3, 2026
| bson.D{{Key: "$sample", Value: bson.D{{Key: "size", Value: int32(sampleSize)}}}}, | ||
| bson.D{{Key: "$sort", Value: bson.D{{Key: DefaultDocumentKeyColumnName, Value: 1}}}}, | ||
| bson.D{{Key: "$project", Value: bson.D{{Key: DefaultDocumentKeyColumnName, Value: 1}}}}, | ||
| bson.D{{Key: "$sort", Value: bson.D{{Key: DefaultDocumentKeyColumnName, Value: 1}}}}, |
Contributor
Author
There was a problem hiding this comment.
more memory-efficient to sort after project to sort just the _ids (vs. sorting the entire documents).
jgao54
force-pushed
the
mongo-id-partitioning-fixes
branch
from
f20f8ce to
f3ee4af
Compare
jgao54
force-pushed
the
mongo-id-partitioning-fixes
branch
from
f3ee4af to
b2cb5f8
Compare
jgao54
force-pushed
the
mongo-id-partitioning-fixes
branch
from
b2cb5f8 to
fedb7df
Compare
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
2 similar comments
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
ilidemi
approved these changes
Jul 7, 2026
Co-authored-by: Ilia Demianenko <ilia.demianenko@clickhouse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups for MongoDB parallel snapshotting #4487 to introduce NumericPartitions; this avoids missing data during initial snapshots when there are interior fractional _ids.
A few other smaller clean-up, with inline comments.