Pin go-mysql digest as well#4547
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
pfcoperez
left a comment
There was a problem hiding this comment.
Pin LGTM,
Shouldn't we also include it at:
peerdb/flow/cmd/check_pinned_versions/main.go
Lines 19 to 22 in c2a2c33
?
pfcoperez
left a comment
There was a problem hiding this comment.
Prior to the changes in this PR (main branch), a Renovate simulation:
LOG_LEVEL=debug npx renovate --platform=local --require-config=ignored --repository-cache=reset | sed '1,/packageFiles with updates/d' | sed 's/"config": {/{/' | sed '/DEBUG/,$d' | jq '.gomod[].deps[] | select(.depName == "github.com/go-mysql-org/go-mysql")' Still proposed the digest bump:
{
"datasource": "go",
"depType": "require",
"depName": "github.com/go-mysql-org/go-mysql",
"currentValue": "v1.15.1-0.20260701093637-35ca5c6ee8c8",
"currentDigest": "35ca5c6ee8c8",
"digestOneAndOnly": true,
"versioning": "loose",
"managerData": {
"multiLine": true,
"lineNumber": 37
},
"updates": [
{
"updateType": "digest",
"newValue": "v1.15.1-0.20260701093637-35ca5c6ee8c8",
"newDigest": "a57884f25cf0008867559df9012a6498bb17df70",
"branchName": "renovate/github.com-go-mysql-org-go-mysql-digest"
}
],
"packageName": "github.com/go-mysql-org/go-mysql",
"warnings": [],
"sourceUrl": "https://github.com/go-mysql-org/go-mysql",
"mostRecentTimestamp": "2026-05-06T12:41:30.000Z",
"currentVersion": "v1.15.1-0.20260701093637-35ca5c6ee8c8",
"fixedVersion": "v1.15.1-0.20260701093637-35ca5c6ee8c8"
}
{
"datasource": "go",
"depType": "require",
"depName": "github.com/go-mysql-org/go-mysql",
"currentValue": "v1.15.0",
"managerData": {
"multiLine": true,
"lineNumber": 11
},
"updates": [],
"packageName": "github.com/go-mysql-org/go-mysql",
"versioning": "semver",
"warnings": [],
"sourceUrl": "https://github.com/go-mysql-org/go-mysql",
"mostRecentTimestamp": "2026-05-06T12:41:30.000Z",
"currentVersion": "v1.15.0",
"currentVersionTimestamp": "2026-05-06T12:41:30.000Z",
"currentVersionAgeInDays": 61,
"fixedVersion": "v1.15.0"
}With these changes, the output is:
{
"datasource": "go",
"depType": "require",
"depName": "github.com/go-mysql-org/go-mysql",
"currentValue": "v1.15.1-0.20260701093637-35ca5c6ee8c8",
"currentDigest": "35ca5c6ee8c8",
"digestOneAndOnly": true,
"versioning": "loose",
"managerData": {
"multiLine": true,
"lineNumber": 37
},
"updates": [
{
"updateType": "digest",
"newValue": "v1.15.1-0.20260701093637-35ca5c6ee8c8",
"newDigest": "a57884f25cf0008867559df9012a6498bb17df70",
"branchName": "renovate/github.com-go-mysql-org-go-mysql-digest"
}
],
"packageName": "github.com/go-mysql-org/go-mysql",
"warnings": [],
"sourceUrl": "https://github.com/go-mysql-org/go-mysql",
"mostRecentTimestamp": "2026-05-06T12:41:30.000Z",
"currentVersion": "v1.15.1-0.20260701093637-35ca5c6ee8c8",
"fixedVersion": "v1.15.1-0.20260701093637-35ca5c6ee8c8"
}
{
"datasource": "go",
"depType": "require",
"depName": "github.com/go-mysql-org/go-mysql",
"currentValue": "v1.15.0",
"managerData": {
"multiLine": true,
"lineNumber": 11
},
"updates": [],
"packageName": "github.com/go-mysql-org/go-mysql",
"versioning": "semver",
"warnings": [],
"sourceUrl": "https://github.com/go-mysql-org/go-mysql",
"mostRecentTimestamp": "2026-05-06T12:41:30.000Z",
"currentVersion": "v1.15.0",
"currentVersionTimestamp": "2026-05-06T12:41:30.000Z",
"currentVersionAgeInDays": 61,
"fixedVersion": "v1.15.0"
}Which is identical so this PR is not taking the desired effect.
pfcoperez
left a comment
There was a problem hiding this comment.
In my previous test I was not loading the configuration properly and the selected JSON in the logs included disabled rules. Confirmed again:
➜ peerdb git:(renovate-no-mysql-digest) ✗ LOG_LEVEL=debug npx renovate --platform=local --require-config=optional --repository-cache=reset | grep 'flattened updates found' | tr ',' '\n' | grep mysql
github.com/go-mysql-org/go-mysql
➜ peerdb git:(renovate-no-mysql-digest) ✗ LOG_LEVEL=debug npx renovate --platform=local --require-config=optional --repository-cache=reset | grep 'flattened updates found' | tr ',' '\n' | grep mysql
These changes work, I wonder if you want to add the pin to the go checker but I am not blocking the PR.
go-mysql was pinned as we're using a pseudoversion from main and don't want to follow the rest of main. Turns out just version is not enough for renovate (#4546), adding digest as well