fix(tests): update peer config to avoid using stale config from previous local run#4552
Merged
Merged
Conversation
dtunikov
changed the title
dtunikov
commented
Jul 8, 2026
| pool, err := catalogTestAccessPool() | ||
| require.NoError(t, err) | ||
| res, err := utils.CreatePeerNoValidate(t.Context(), shared.CatalogPool{Pool: pool}, peer, false) | ||
| res, err := utils.CreatePeerNoValidate(t.Context(), shared.CatalogPool{Pool: pool}, peer, true) |
Collaborator
Author
There was a problem hiding this comment.
otherwise local debug gets confusing
if you run with mysql-gtid and later with mysql-pos
mysql-pos would use the old config and try to reach port 3306 even if mysql_port env is set to 3307..
got this problem a few times when was working on mysql connector recently
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.