classify error as retryable when pipe closed in deadlineCappableConn#4567
Open
jgao54 wants to merge 1 commit into
Open
classify error as retryable when pipe closed in deadlineCappableConn#4567jgao54 wants to merge 1 commit into
jgao54 wants to merge 1 commit into
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Classify a transient error that can happen with DeadlineCapableConn. In #4380 we introduced an in-memory transport between connector and ssh using net.Pipe() to allow it to respect deadlines. This introduced a scenario where if the ssh tunnel is processing read/write when the pipe is closed, we get an
io.ErrClosedPipethat ended up unhandled. The error is wrapped in anSSHTunnelClosedErrorto be precise, to avoid blindly handle allio.ErrClosedPipethat could hide future unrelated bugs.Fixes: DBI-896