[TA-4743]: auth0 & custom backend integration pages#31
Conversation
📝 WalkthroughWalkthroughThe documentation for Auth0 and custom backend integrations was completely rewritten, transforming placeholder notes into comprehensive step-by-step guides. The sidebar configuration was updated by commenting out and removing certain entries. Minor dependency and configuration changes were made in example and root Changes
Sequence Diagram(s)No sequence diagrams generated, as changes are limited to documentation and configuration. Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
GuillemGarciaDev
changed the title
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
docs/sidebars.ts (1)
52-57: Commented-out items linger; delete or document TODODead code in configuration files tends to become stale and confuses new contributors. If the “Guides” section is intentionally dropped, remove the commented block or add a TODO with a ticket reference.
docs/docs/integrations/auth0.md (1)
33-50: Replace bold text used as section titles with proper headings (MD036)Markdown-lint flags
**Allowed Callback URLs:**,**Allowed Logout URLs:**,**Allowed Web Origins:**. Use heading syntax for accessibility and sidebar generation.-**Allowed Callback URLs:** +### Allowed Callback URLs … -**Allowed Logout URLs:** +### Allowed Logout URLs … -**Allowed Web Origins:** +### Allowed Web Originsdocs/docs/integrations/custom-backend.md (2)
46-52: Headings, not bold, for claim sections (MD036)The same bold-as-heading pattern appears here; convert to
###to satisfy linters and improve navigation.
103-106: Use constant-time comparison for JWT payloads
if claims.fatxn != sign_payload { … }performs a byte-wise early-exit comparison susceptible to timing analysis. For cryptographic material, recommendsubtle::ConstantTimeEq(or similar) to avoid leaking equality information.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
docs/docs/integrations/auth0.md(1 hunks)docs/docs/integrations/custom-backend.md(1 hunks)docs/sidebars.ts(1 hunks)examples/spa/package.json(2 hunks)package.json(0 hunks)
💤 Files with no reviewable changes (1)
- package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: in the @frontend/price-service package, it's important to export the data-access layer modules (like...
Learnt from: JordiParraCrespo
PR: Peersyst/near-mobile#190
File: packages/frontend/price-service/package.json:18-25
Timestamp: 2025-04-17T02:49:42.537Z
Learning: In the @frontend/price-service package, it's important to export the data-access layer modules (like price-service and errors) in the package.json exports configuration to enable other packages to use them when needed.
Applied to files:
docs/sidebars.ts
🪛 markdownlint-cli2 (0.17.2)
docs/docs/integrations/custom-backend.md
68-68: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
92-92: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
120-120: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
136-136: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
141-141: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: integration-packages / Build
🔇 Additional comments (3)
examples/spa/package.json (1)
24-25: Verify CI installs devDependencies before running the buildVite plugins (including vite-plugin-node-polyfills) are applied at build time. If your CI invokes
npm ci --productionor omits devDependencies, those polyfills won’t be included in the production bundle and may cause runtime errors in the browser.Please confirm your CI pipeline installs devDependencies prior to calling
vite build. For example:
- Check your
.github/workflows/*(or other CI config files like.gitlab-ci.yml,Jenkinsfile,azure-pipelines.yml) for anynpm ci,npm install, ornpm run buildsteps.- Ensure they do not include
--productionor setNODE_ENV=productionbefore installing.- Verify that the build step is executed after all dependencies (including devDependencies) are installed.
docs/docs/integrations/auth0.md (1)
15-18: Broken relative link risk
[FastAuth Browser SDK](../sdk/browser/getting-started.md)climbs only one level, resulting indocs/sdk/..., while the correct path fromdocs/integrationsis../sdk/browser/getting-started.mdor../../sdk/browser/getting-started.mddepending on your Docusaurusdocsroot. Please verify the link renders.docs/docs/integrations/custom-backend.md (1)
138-147: Confirm attached deposit value in registration example
--deposit 1.03is unusually high for a router metadata call and may mislead users. Typical guard registration on testnet needs ≈1 NEARplus gas. Verify the exact amount and update the snippet.
2 participants
[TA-4743]: add auth0 & custom backend integration pages
Changes 🛠️
docs
auth0integration pagecustom-backendintegration pageexamples/spa
vite-plugin-node-polyfillsdependency versionSummary by CodeRabbit
Documentation
Chores