Untie prefix from Broker communication paths #2108
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This goroutine listens for requests from xrdcl-pelican, which are sent when xrdcl-pelican wants to connect to the origin through the broker.
Originally, the Broker code assumed a one-to-one correspondence between origin and exported prefix. Communication paths were identified using both the origin hostname and the exported prefix. This commit refactors the code so that all communication paths rely solely on the origin identifier (hostname + port), removing dependency on the exported prefix.
Modified the Broker test to include recent updates. This includes passing the full origin identifier (URL plus port) to identify the communication channel and decoupling from exported prefixes. To support this, I implemented a custom getFreePort() function in the test to obtain an available port beforehand, which was necessary for registering the origin. Also, I included the Registry module in InitServer, which was necessary to ensure the registry URL is populated during the federation discovery flow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the code so that all communication paths rely solely on the origin identifier (hostname + port) and no longer depend on the prefixes exported by the origin.