Skip to content

Add meaningful page titles #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CannonLock
Copy link
Contributor

@CannonLock CannonLock commented Mar 27, 2025

  • Page specific titles, so rather then only "Pelican Platform" you will see "Register Cache | Origin" for example
  • Create MetaLayout for an unobtrusive layout for metadata inclusion

- Create MetaLayout for an unobtrusive layout for metadata inclusion
@CannonLock CannonLock requested a review from Copilot March 27, 2025 20:21
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the metadata used for page titles across several routes to create more meaningful and concise titles. Key changes include converting some title values to use template objects and removing redundant description properties for a cleaner metadata layout.

Reviewed Changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.

Show a summary per file
File Description
web_ui/frontend/app/registry/namespace/edit/layout.tsx Adds metadata for the "Edit Namespace" page using MetaLayout.
web_ui/frontend/app/registry/layout.tsx Updates the registry home page metadata with a title template and removes the description.
web_ui/frontend/app/registry/denied/layout.tsx Defines metadata for the "Denied Registrations" page.
web_ui/frontend/app/registry/cache/register/layout.tsx Sets metadata for the "Register Cache" page.
web_ui/frontend/app/registry/cache/edit/layout.tsx Sets metadata for the "Edit Cache" page.
web_ui/frontend/app/origin/metrics/layout.tsx Introduces metadata for the "Service Metrics" page.
web_ui/frontend/app/origin/layout.tsx Simplifies metadata for the origin home page by using a plain title.
web_ui/frontend/app/origin/issuer/layout.tsx Sets metadata for the "Issuer Configuration" page.
web_ui/frontend/app/origin/globus/layout.tsx Defines metadata for the "Globus Exports" page.
web_ui/frontend/app/layout.tsx Updates the main app layout metadata to include a title template with default and a description.
web_ui/frontend/app/director/metrics/layout.tsx Adds metadata for the "Metrics" page.
web_ui/frontend/app/director/map/layout.tsx Sets metadata for the "Service Map" page.
web_ui/frontend/app/director/layout.tsx Updates director layout metadata with a title template and removes the description.
web_ui/frontend/app/config/layout.tsx Simplifies configuration page metadata by updating the title.
web_ui/frontend/app/cache/layout.tsx Updates cache layout metadata by shortening the title.
web_ui/frontend/app/api/docs/layout.tsx Introduces metadata for the API Documentation page using MetaLayout.
web_ui/frontend/app/(login)/layout.tsx Simplifies login page metadata by updating the title.
web_ui/frontend/app/(login)/initialization/password/layout.tsx Adds metadata for the "Create Password" page using MetaLayout.
web_ui/frontend/app/(login)/initialization/code/layout.tsx Adds metadata for the "Initialize Admin" page using MetaLayout.
web_ui/frontend/app/(landing)/layout.tsx Updates landing page metadata by revising the title.
Comments suppressed due to low confidence (2)

web_ui/frontend/app/registry/layout.tsx:26

  • [nitpick] Consider standardizing metadata title formatting across pages for consistency. If a title template is preferred on some pages, evaluate whether all pages should follow the same pattern or if plain strings are acceptable.
  title: {

web_ui/frontend/app/director/layout.tsx:25

  • [nitpick] Consider standardizing metadata title formatting across pages for consistency. Aligning the approach (template versus plain string) can improve maintainability across the codebase.
  title: {

@CannonLock CannonLock added the enhancement New feature or request label Mar 27, 2025
@CannonLock CannonLock linked an issue Mar 27, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better page titles
1 participant